Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create node #1855

Merged
merged 10 commits into from
Nov 15, 2024
Merged

Feature/create node #1855

merged 10 commits into from
Nov 15, 2024

Conversation

shivamka1
Copy link
Collaborator

@shivamka1 shivamka1 commented Nov 8, 2024

What changes were proposed in this pull request?

Add create node api to create node if doesn't already exits. Fail otherwise.
Removes the ability to create RemoteGraph directly, can now only be done through the client

Why are the changes needed?

An alternative way to create node besides add node which updates the node if node already exists in the graph

Does this PR introduce any user-facing change? If yes is this documented?

Documentation and Graphql docs

How was this patch tested?

Unit tests

Are there any further changes required?

No

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run tidy, otherwise looks good

python/tests/graphql/edit_graph/test_graphql.py Outdated Show resolved Hide resolved
raphtory/src/db/graph/graph.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions and then we can get it in :)

@miratepuffin miratepuffin merged commit a9a16ba into master Nov 15, 2024
19 checks passed
@miratepuffin miratepuffin deleted the feature/create_node branch November 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants