Feature/node state ops #1854
Merged
Feature/node state ops #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
feature/NodeStateOps
branch
from
0ec7984 to
40b71c4
Compare
ljeub-pometry
force-pushed
the
feature/NodeStateOps
branch
from
517783c to
335b259
Compare
| fn filtered<G: GraphViewOps<'graph>>(&self, graph: G) -> Self::Filtered<G>; | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy)] |
There was a problem hiding this comment.
I wonder if many of these could just be special cases of a more generic
struct NodeOpFn<O, F: Fn(&GraphStorage, VID) -> O>(F)
and could be just made from constructors like
fn id()-> ...
There was a problem hiding this comment.
If you do this you can no longer name the type which causes a bunch of problems, though maybe we can get away with fn
There was a problem hiding this comment.
This file alone makes me SERIOUSLY want to reconsider the way we use generics to filter the graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make lazy node state views support time ops and layer ops
Why are the changes needed?
so you can get a windowed degree for all nodes in the graph for example
Does this PR introduce any user-facing change? If yes is this documented?
Adds additional APIs that are documented
How was this patch tested?
Needs more tests
Are there any further changes required?