Fix existing rust Dockerfile #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamka1
added a commit
that referenced
this pull request
Nov 4, 2024
shivamka1
added a commit
that referenced
this pull request
Nov 4, 2024
shivamka1
approved these changes
Nov 6, 2024
shivamka1
added a commit
that referenced
this pull request
Nov 6, 2024
* Adding initial docker files * impl review comments and add server config debug log * add server config debug log * Updates from #1844, add more configs to server * more changes from #1844 * make server configs parsable as args * make makefile accept args to pass to graphqlserver * fix python docker * add package and rust version as label and add dockerignore * add github workflow * deactivate storage * extract rust and package versions * impl review comments * fix pacakge name * upgrade rust * levelup rust ver * fix build --------- Co-authored-by: Ben Steer <[email protected]> Co-authored-by: Shivam Kapoor <[email protected]> Co-authored-by: Shivam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
Are there any further changes required?