Disk merge #1678
Merged
Disk merge #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
disk_merge
branch
3 times, most recently
from
9305293 to
030bea9
Compare
miratepuffin
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds support for merging
DiskGraphs (only available with the private storage)Why are the changes needed?
Makes it possible to update an on-disk graph by merging in another graph.
Does this PR introduce any user-facing change? If yes is this documented?
Adds a method for merging to
DiskGraph(python method and documentation pending)How was this patch tested?
New tests for the merging functionality (including property tests)
Are there any further changes required?
More testing required (especially for Properties and node additions)