Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max weight matching #1602

Merged
merged 7 commits into from
Nov 13, 2024
Merged

max weight matching #1602

merged 7 commits into from
Nov 13, 2024

Conversation

miratepuffin
Copy link
Collaborator

@miratepuffin miratepuffin commented May 15, 2024

What changes were proposed in this pull request?

Added maximum-weighted matching based on "Efficient Algorithms for Finding Maximum Matching in Graphs" by Zvi Galil, ACM Computing Surveys, 1986.

Why are the changes needed?

More algorithm always good,

Does this PR introduce any user-facing change? If yes is this documented?

New docs included

How was this patch tested?

New tests and internal usecase

Are there any further changes required?

Some internal clean up of the algorithm + more tests

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could put all the state into a struct and make this a lot cleaner.

Fix the return type so this returns a matching between nodes instead of pairs of usize!

raphtory/Cargo.toml Outdated Show resolved Hide resolved
@ljeub-pometry ljeub-pometry force-pushed the algorithm/max_weight_matching branch from f739271 to 36d4494 Compare November 13, 2024 08:48
@ljeub-pometry ljeub-pometry force-pushed the algorithm/max_weight_matching branch from 36d4494 to 0aa2ab6 Compare November 13, 2024 09:34
@miratepuffin miratepuffin merged commit b6f020c into master Nov 13, 2024
19 checks passed
@miratepuffin miratepuffin deleted the algorithm/max_weight_matching branch November 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants