Existential Amount for Cross Chain transfer #267
Conversation
🦋 Changeset detectedLatest commit: 68c3484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update introduces a new Changes
Possibly related issues
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (5)
packages/thea/src/sdk/substrate/interlay.ts (1)
Line range hint
51-59: Consider usingfor...ofloops for better performance and readability when iterating over arrays.- supportedAssets.forEach((asset) => { + for (const asset of supportedAssets) {Also applies to: 69-78
packages/thea/src/sdk/substrate/polkadot.ts (2)
Line range hint
51-59: Consider refactoring theforEachloops tofor...ofloops for better performance and readability.- supportedAssets.forEach((asset) => { + for (const asset of supportedAssets) {Also applies to: 69-78
Line range hint
4-5: Optimize imports by using TypeScript's type-only import syntax where applicable.- import { AnyChain } from "@moonbeam-network/xcm-types"; + import type { AnyChain } from "@moonbeam-network/xcm-types";Also applies to: 7-18, 18-19
packages/thea/src/sdk/substrate/polkadex.ts (2)
Line range hint
51-59: Consider refactoring theforEachloops tofor...ofloops for better performance and readability.- supportedAssets.forEach((asset) => { + for (const asset of supportedAssets) {Also applies to: 69-78
Line range hint
3-4: Optimize imports by using TypeScript's type-only import syntax where applicable.- import { AnyChain, ChainType } from "@moonbeam-network/xcm-types"; + import type { AnyChain, ChainType } from "@moonbeam-network/xcm-types";Also applies to: 7-18, 18-19
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (15)
- .changeset/great-kings-mix.md (1 hunks)
- packages/thea/src/config/substrate/config/polkadex.ts (1 hunks)
- packages/thea/src/config/substrate/helpers.ts (2 hunks)
- packages/thea/src/config/types.ts (1 hunks)
- packages/thea/src/sdk/substrate/assetHub.ts (2 hunks)
- packages/thea/src/sdk/substrate/astar.ts (2 hunks)
- packages/thea/src/sdk/substrate/bifrost.ts (2 hunks)
- packages/thea/src/sdk/substrate/interlay.ts (2 hunks)
- packages/thea/src/sdk/substrate/moonbeam.ts (2 hunks)
- packages/thea/src/sdk/substrate/phala.ts (2 hunks)
- packages/thea/src/sdk/substrate/polkadex.ts (2 hunks)
- packages/thea/src/sdk/substrate/polkadot.ts (2 hunks)
- packages/thea/src/sdk/substrate/unique.ts (2 hunks)
- packages/thea/src/sdk/types.ts (1 hunks)
- packages/ui/src/components/input.tsx (1 hunks)
Additional Context Used
LanguageTool (1)
.changeset/great-kings-mix.md (1)
Near line 6: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...d a new enum for ChainType and minor UI fix
Rule ID: AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER
Biome (52)
packages/thea/src/config/substrate/helpers.ts (2)
1-5: Some named imports are only used as types.
6-7: Some named imports are only used as types.
packages/thea/src/config/types.ts (1)
1-1: This enum declaration contains members that are implicitly initialized.
packages/thea/src/sdk/substrate/assetHub.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/astar.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/bifrost.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/interlay.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/moonbeam.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/phala.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/polkadex.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
3-4: Some named imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/polkadot.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/substrate/unique.ts (5)
51-59: Prefer for...of instead of forEach.
69-78: Prefer for...of instead of forEach.
4-5: All these imports are only used as types.
7-18: Some named imports are only used as types.
18-19: All these imports are only used as types.
packages/thea/src/sdk/types.ts (1)
1-1: All these imports are only used as types.
packages/ui/src/components/input.tsx (3)
4-14: Some named imports are only used as types.
22-23: Some named imports are only used as types.
23-24: Some named imports are only used as types.
Additional comments not posted (20)
packages/thea/src/config/types.ts (1)
3-3: The addition ofEvmSubstrateto theChainTypeenum aligns with the PR's objectives to support new chain types.packages/thea/src/config/substrate/helpers.ts (1)
15-18: The updated logic inchangeSubstrateToBaseChaincorrectly handles the newEvmSubstratechain type.packages/thea/src/sdk/types.ts (1)
15-16: The addition ofsourceFeeExistentialtoTransferConfigis well-integrated and supports handling existential deposits as described in the PR.packages/ui/src/components/input.tsx (1)
90-90: The addition offlex-1to thePrimarycomponent enhances layout flexibility, aligning with the PR's objectives for minor UI improvements.packages/thea/src/sdk/substrate/interlay.ts (1)
135-141: The integration ofsourceFeeExistentialingetTransferConfigcorrectly utilizes the existential deposit data, enhancing the transfer configuration capabilities.packages/thea/src/sdk/substrate/bifrost.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/astar.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/phala.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/unique.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/assetHub.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/moonbeam.ts (2)
135-141: The addition ofsourceFeeExistentialis correctly implemented and aligns with the PR's objectives to handle existential deposits.
168-168: The inclusion ofsourceFeeExistentialin the transfer configuration is correctly implemented.packages/thea/src/sdk/substrate/polkadot.ts (1)
Line range hint
135-168: The addition ofsourceFeeExistentialaligns with the PR's objectives and is implemented correctly.packages/thea/src/sdk/substrate/polkadex.ts (1)
Line range hint
135-168: The addition ofsourceFeeExistentialaligns with the PR's objectives and is implemented correctly.packages/thea/src/config/substrate/config/polkadex.ts (1)
155-155: The update of thedestinationFeeamount to0.05is appropriate and aligns with the PR's objectives.
Description -
We have to return Existential Deposit value from
TransferConfigtype.Update
ChainTypeforChaintype. Add new enumEvmSubstratein it.Summary by CodeRabbit
New Features
EvmSubstrateto enhance chain type handling.sourceFeeExistentialto various classes for more detailed fee calculations.Improvements
destinationFeeamount to0.05for more accurate fee representation.Bug Fixes
@polkadex/theaand@polkadex/ux.Refactor
TransferConfigfor better readability and organization.