-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #230
Version Packages #230
Conversation
WalkthroughThe update to Changes
Possibly related issues
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Files skipped from review due to trivial changes (1)
Files skipped from review as they are similar to previous changes (1)
Additional Context UsedLanguageTool (58)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
|
||
### Patch Changes | ||
|
||
- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comma after "Interlay chain" for better readability.
- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex.
+ 2ab5735: This task aims to integrate Astar chain & Interlay chain, and more remaining chains which will allow deposit from respective chains to Polkadex.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality. | |
2ab5735: This task aims to integrate Astar chain & Interlay chain, and more remaining chains which will allow deposit from respective chains to Polkadex. |
- [x] Unique to Polkadex - UNQ | ||
- [x] Phala to Polkadex - PHA | ||
|
||
from respective chains to Polkadex network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start the sentence with an uppercase letter for consistency.
- from respective chains to Polkadex network.
+ From respective chains to Polkadex network.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
from respective chains to Polkadex network. | |
From respective chains to Polkadex network. |
f89dc38
to
bb241d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
||
### Major Changes | ||
|
||
- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the spelling of "their" and specify "other networks" instead of "other network" for clarity.
- In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.
+ In this task, we will be adding the withdrawal logic for THEA so that users can withdraw their assets from Polkadex network to other networks.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network. | |
- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdrawal logic for THEA so that users can withdraw their assets from Polkadex network to other networks. |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@polkadex/[email protected]
Major Changes
7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.
@polkadex/[email protected]
Patch Changes
2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality.
from respective chains to Polkadex network.
Updated dependencies [7a112a3]
Summary by CodeRabbit
New Features
Documentation