Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #230

Merged
merged 1 commit into from
May 1, 2024
Merged

Version Packages #230

merged 1 commit into from
May 1, 2024

Conversation

Gauthamastro
Copy link
Contributor

@Gauthamastro Gauthamastro commented Apr 30, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@polkadex/[email protected]

Major Changes

  • 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.

    1. Polkadex to AssetHub - USDT, DED, PINK, USDC
    2. Polkadex to Astar - ASTR
    3. Polkadex to Moonbeam - GLMR
    4. Polkadex to Interlay - IBTC
    5. Polkadex to Unique - UNQ
    6. Polkadex to Polkadot - DOT
    7. Polkadex to Phala - PHA

@polkadex/[email protected]

Patch Changes

  • 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality.

    • Astar to Polkadex - ASTR
    • Interlay to Polkadex - IBTC
    • Moonbeam to Polkadex - GLMR
    • Unique to Polkadex - UNQ
    • Phala to Polkadex - PHA

    from respective chains to Polkadex network.

  • Updated dependencies [7a112a3]

Summary by CodeRabbit

  • New Features

    • Integrated Astar, Interlay, Moonbeam, Unique, and Phala chains with Polkadex enabling deposits from these chains.
    • Added withdrawal logic to transfer assets from Polkadex to other networks including various cryptocurrencies.
  • Documentation

    • Updated version numbers in documentation for clarity and consistency.

Copy link

coderabbitai bot commented Apr 30, 2024

Walkthrough

The update to @polkadex/cross-chain version 0.3.1 includes integration with several new chains (Astar, Interlay, Moonbeam, Unique, and Phala) to enhance cross-chain functionality, enabling asset deposits from these chains to Polkadex.

Changes

File Path Change Summary
apps/cross-chain/CHANGELOG.md Integrated Astar, Interlay, Moonbeam, Unique, and Phala chains; no changes to exported entities.
apps/cross-chain/package.json Updated version from "0.3.0" to "0.3.1"; no changes to exported entities.
packages/thea/CHANGELOG.md Added withdraw logic for transferring assets from Polkadex to other networks.
packages/thea/package.json Updated version from "4.1.0" to "5.0.0"; no changes to exported entities.

Possibly related issues

Poem

🌟🐇 A Poem by CodeRabbit 🐇🌟

In the world of code and chain,
New connections we attain.
Astar, Moonbeam, light the way,
Across the chains, our assets sway.
Polkadex grows, so vast, so bright,
In blockchain skies, a thrilling flight! 🚀


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6c4850d and bb241d0.
Files selected for processing (4)
  • apps/cross-chain/CHANGELOG.md (1 hunks)
  • apps/cross-chain/package.json (1 hunks)
  • packages/thea/CHANGELOG.md (1 hunks)
  • packages/thea/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/thea/package.json
Files skipped from review as they are similar to previous changes (1)
  • apps/cross-chain/package.json
Additional Context Used
LanguageTool (58)
apps/cross-chain/CHANGELOG.md (26)

Near line 7: Possible spelling mistake found.
Context: ... - 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaini...


Near line 7: Possible missing comma found.
Context: ...ain & Interlay chain and more remaining chains which will allow deposit from respectiv...


Near line 7: Possible spelling mistake found.
Context: ...allow deposit from respective chains to Polkadex. The objective is to enhance cross-chai...


Near line 9: Possible spelling mistake found.
Context: ...nce cross-chain functionality. - [x] Astar to Polkadex - ASTR - [x] Interlay to ...


Near line 9: Possible spelling mistake found.
Context: ...-chain functionality. - [x] Astar to Polkadex - ASTR - [x] Interlay to Polkadex - I...


Near line 9: Possible spelling mistake found.
Context: ...tionality. - [x] Astar to Polkadex - ASTR - [x] Interlay to Polkadex - IBTC -...


Near line 10: Possible spelling mistake found.
Context: ... to Polkadex - ASTR - [x] Interlay to Polkadex - IBTC - [x] Moonbeam to Polkadex - G...


Near line 10: Possible spelling mistake found.
Context: ...x - ASTR - [x] Interlay to Polkadex - IBTC - [x] Moonbeam to Polkadex - GLMR -...


Near line 11: Possible spelling mistake found.
Context: ... to Polkadex - IBTC - [x] Moonbeam to Polkadex - GLMR - [x] Unique to Polkadex - UNQ...


Near line 11: Possible spelling mistake found.
Context: ...x - IBTC - [x] Moonbeam to Polkadex - GLMR - [x] Unique to Polkadex - UNQ - [x...


Near line 12: Possible spelling mistake found.
Context: ...am to Polkadex - GLMR - [x] Unique to Polkadex - UNQ - [x] Phala to Polkadex - PHA ...


Near line 12: Possible spelling mistake found.
Context: ...dex - GLMR - [x] Unique to Polkadex - UNQ - [x] Phala to Polkadex - PHA from...


Near line 13: Possible spelling mistake found.
Context: ... - [x] Unique to Polkadex - UNQ - [x] Phala to Polkadex - PHA from respective ch...


Near line 13: Possible spelling mistake found.
Context: ...ique to Polkadex - UNQ - [x] Phala to Polkadex - PHA from respective chains to Polk...


Near line 15: This sentence does not start with an uppercase letter.
Context: ... UNQ - [x] Phala to Polkadex - PHA from respective chains to Polkadex network. ...


Near line 15: Possible spelling mistake found.
Context: ...adex - PHA from respective chains to Polkadex network. - Updated dependencies [7a112...


Near line 24: This verb may not be in the correct form. Consider using a different form for this context.
Context: ... Changes - 966fba6: This task is about to add the metadata of supported assets for Po...


Near line 24: Possible spelling mistake found.
Context: ...dd the metadata of supported assets for Polkadex network and make the project build succ...


Near line 24: Possible spelling mistake found.
Context: ...adex network and make the project build succesful (if it breaks anything) - a79b5ab: In t...


Near line 25: Possible spelling mistake found.
Context: ... a79b5ab: In this PR, we will be adding Polkadot XCM chain for DOT asset transfer. Users...


Near line 25: Possible spelling mistake found.
Context: ...s would be allowed to transfer DOT from Polkadot to Polkadex. ### Patch Changes - Upda...


Near line 25: Possible spelling mistake found.
Context: ...llowed to transfer DOT from Polkadot to Polkadex. ### Patch Changes - Updated dependen...


Near line 37: Possible spelling mistake found.
Context: ... this PR, we will be adding support for DED, PINK and USDC token which would be tra...


Near line 37: Possible spelling mistake found.
Context: ...ill be adding support for DED, PINK and USDC token which would be transferable from ...


Near line 37: Possible spelling mistake found.
Context: ... token which would be transferable from AssetHub to Polkadex. - dff153a: This PR aims to...


Near line 37: Possible spelling mistake found.
Context: ... would be transferable from AssetHub to Polkadex. - dff153a: This PR aims to add the THE...

packages/thea/CHANGELOG.md (32)

Near line 1: Possible spelling mistake found.
Context: # @polkadex/thea ## 5.0.0 ### Major Changes - 7a112a3...


Near line 7: Possible spelling mistake found.
Context: ... the chains for cross chain transfer to Polkadex. In this task, we will be adding the wi...


Near line 7: The word ‘withdraw’ is not a noun. Did you mean “withdrawal”?
Context: ...ex. In this task, we will be adding the withdraw logic for THEA so that user can withdra...


Near line 7: Possible spelling mistake found.
Context: ...ogic for THEA so that user can withdraw thier assets from Polkadex network to other n...


Near line 7: Possible spelling mistake found.
Context: ...hat user can withdraw thier assets from Polkadex network to other network. 1. Polkade...


Near line 7: Use the plural noun, or add a word such as ‘the’ or ‘some’ in front of ‘other’.
Context: ...w thier assets from Polkadex network to other network. 1. Polkadex to AssetHub - USDT, DED...


Near line 9: Possible spelling mistake found.
Context: ...olkadex network to other network. 1. Polkadex to AssetHub - USDT, DED, PINK, USDC 2...


Near line 9: Possible spelling mistake found.
Context: ...ork to other network. 1. Polkadex to AssetHub - USDT, DED, PINK, USDC 2. Polkadex t...


Near line 9: Possible spelling mistake found.
Context: ...ork. 1. Polkadex to AssetHub - USDT, DED, PINK, USDC 2. Polkadex to Astar - AS...


Near line 9: Possible spelling mistake found.
Context: ...Polkadex to AssetHub - USDT, DED, PINK, USDC 2. Polkadex to Astar - ASTR 3. Polk...


Near line 10: Possible spelling mistake found.
Context: ...o AssetHub - USDT, DED, PINK, USDC 2. Polkadex to Astar - ASTR 3. Polkadex to Moonbe...


Near line 10: Possible spelling mistake found.
Context: ... USDT, DED, PINK, USDC 2. Polkadex to Astar - ASTR 3. Polkadex to Moonbeam - GLMR...


Near line 10: Possible spelling mistake found.
Context: ...ED, PINK, USDC 2. Polkadex to Astar - ASTR 3. Polkadex to Moonbeam - GLMR 4. P...


Near line 11: Possible spelling mistake found.
Context: ...USDC 2. Polkadex to Astar - ASTR 3. Polkadex to Moonbeam - GLMR 4. Polkadex to Int...


Near line 12: Possible spelling mistake found.
Context: ...R 3. Polkadex to Moonbeam - GLMR 4. Polkadex to Interlay - IBTC 5. Polkadex to Uni...


Near line 12: Possible spelling mistake found.
Context: ...beam - GLMR 4. Polkadex to Interlay - IBTC 5. Polkadex to Unique - UNQ 6. Polk...


Near line 13: Possible spelling mistake found.
Context: ...R 4. Polkadex to Interlay - IBTC 5. Polkadex to Unique - UNQ 6. Polkadex to Polkad...


Near line 13: Possible spelling mistake found.
Context: ...terlay - IBTC 5. Polkadex to Unique - UNQ 6. Polkadex to Polkadot - DOT 7. Po...


Near line 14: Possible spelling mistake found.
Context: ...IBTC 5. Polkadex to Unique - UNQ 6. Polkadex to Polkadot - DOT 7. Polkadex to Phal...


Near line 14: Possible spelling mistake found.
Context: ...lkadex to Unique - UNQ 6. Polkadex to Polkadot - DOT 7. Polkadex to Phala - PHA ## ...


Near line 15: Possible spelling mistake found.
Context: ...NQ 6. Polkadex to Polkadot - DOT 7. Polkadex to Phala - PHA ## 4.1.0 ### Minor Cha...


Near line 15: Possible spelling mistake found.
Context: ...adex to Polkadot - DOT 7. Polkadex to Phala - PHA ## 4.1.0 ### Minor Changes - 9...


Near line 21: Possible spelling mistake found.
Context: ...dd the metadata of supported assets for Polkadex network and make the project build succ...


Near line 21: Possible spelling mistake found.
Context: ...adex network and make the project build succesful (if it breaks anything) - a79b5ab: In t...


Near line 22: Possible spelling mistake found.
Context: ... a79b5ab: In this PR, we will be adding Polkadot XCM chain for DOT asset transfer. Users...


Near line 22: Possible spelling mistake found.
Context: ...s would be allowed to transfer DOT from Polkadot to Polkadex. ### Patch Changes - Upda...


Near line 22: Possible spelling mistake found.
Context: ...llowed to transfer DOT from Polkadot to Polkadex. ### Patch Changes - Updated dependen...


Near line 38: Possible spelling mistake found.
Context: ... this PR, we will be adding support for DED, PINK and USDC token which would be tra...


Near line 38: Possible spelling mistake found.
Context: ...ill be adding support for DED, PINK and USDC token which would be transferable from ...


Near line 38: Possible spelling mistake found.
Context: ... token which would be transferable from AssetHub to Polkadex. ### Patch Changes - Upda...


Near line 38: Possible spelling mistake found.
Context: ... would be transferable from AssetHub to Polkadex. ### Patch Changes - Updated dependen...


Near line 51: Possible spelling mistake found.
Context: ...1.2 ### Patch Changes - 2dd551f: Thea api

Additional comments not posted (2)
apps/cross-chain/CHANGELOG.md (2)

7-7: Consider adding a comma after "Interlay chain" for better readability.

- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex.
+ 2ab5735: This task aims to integrate Astar chain & Interlay chain, and more remaining chains which will allow deposit from respective chains to Polkadex.

15-15: Start the sentence with an uppercase letter for consistency.

- from respective chains to Polkadex network.
+ From respective chains to Polkadex network.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


### Patch Changes

- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comma after "Interlay chain" for better readability.

- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex.
+ 2ab5735: This task aims to integrate Astar chain & Interlay chain, and more remaining chains which will allow deposit from respective chains to Polkadex.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- 2ab5735: This task aims to integrate Astar chain & Interlay chain and more remaining chains which will allow deposit from respective chains to Polkadex. The objective is to enhance cross-chain functionality.
2ab5735: This task aims to integrate Astar chain & Interlay chain, and more remaining chains which will allow deposit from respective chains to Polkadex.

- [x] Unique to Polkadex - UNQ
- [x] Phala to Polkadex - PHA

from respective chains to Polkadex network.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the sentence with an uppercase letter for consistency.

- from respective chains to Polkadex network.
+ From respective chains to Polkadex network.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
from respective chains to Polkadex network.
From respective chains to Polkadex network.

@github-actions github-actions bot force-pushed the changeset-release/main branch from f89dc38 to bb241d0 Compare May 1, 2024 09:30
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


### Major Changes

- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the spelling of "their" and specify "other networks" instead of "other network" for clarity.

- In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.
+ In this task, we will be adding the withdrawal logic for THEA so that users can withdraw their assets from Polkadex network to other networks.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdraw logic for THEA so that user can withdraw thier assets from Polkadex network to other network.
- 7a112a3: We have successfully added all the chains for cross chain transfer to Polkadex. In this task, we will be adding the withdrawal logic for THEA so that users can withdraw their assets from Polkadex network to other networks.

@nuel77 nuel77 merged commit 27a9424 into main May 1, 2024
@nuel77 nuel77 deleted the changeset-release/main branch May 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants