fix: missing stashId in review page

[Nick-1979]

when rewards destination is stashId (not add to staked) while stake solo in Full screen, in review page destination account info is just a '()'!

Summary by CodeRabbit

• New Features

  • Enhanced the RewardsDestination component to include a stashId field for improved data handling.
  • Updated the ShowValidators component to allow api and chain props to be optional, increasing flexibility.

• Bug Fixes

  • No significant bugs reported; functionality remains consistent with previous versions.

[coderabbitai]

Walkthrough

The changes in the pull request involve updates to the Review.tsx and ShowValidators.tsx files, focusing on enhancing type safety and flexibility of component props. The RewardsDestination component's settings prop now includes a new stashId field, while the api and chain props in the ShowValidators component have been adjusted to allow for undefined and null values. These modifications aim to improve the robustness of the code without altering the existing functionality.

Changes

File	Change Summary
packages/extension-polkagate/src/fullscreen/stake/easyMode/Review.tsx	Updated RewardsDestination component's settings prop to include stashId derived from address and refined type handling for various props.
packages/extension-polkagate/src/popup/staking/solo/stake/partials/ShowValidators.tsx	Modified api and chain prop types to allow for undefined and null, enhancing component flexibility.

Possibly related PRs

• fix: set profile to default on removing the last member of a profile #1534: Changes in ProfileMenu.tsx regarding state management and profile handling may relate to the overall structure and logic improvements in the Review.tsx file.
• refactor: use SimpleModalTitle component #1557: The refactor to use the SimpleModalTitle component may indirectly relate to the changes in Review.tsx, focusing on improving component structure and clarity.
• feat: add BTC and ETH as currency #1563: The addition of BTC and ETH as currencies involves updates to components that enhance user interaction, similar to the updates in Review.tsx.

Suggested reviewers

• AMIRKHANEF

Poem

In the code where rabbits play,
A stashId joins the fray,
With props anew, the data's bright,
Hopping forward, what a sight!
Changes made with care and cheer,
A better path now draws near! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5b861cf and f3ab9ec.

📒 Files selected for processing (2)

• packages/extension-polkagate/src/fullscreen/stake/easyMode/Review.tsx (8 hunks)
• packages/extension-polkagate/src/popup/staking/solo/stake/partials/ShowValidators.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/extension-polkagate/src/fullscreen/stake/easyMode/Review.tsx

🔇 Additional comments (4)

packages/extension-polkagate/src/popup/staking/solo/stake/partials/ShowValidators.tsx (4)

33-33: LGTM! Minor formatting improvement.

The added space after the function name improves code readability and consistency.

---

24-24: LGTM! Consider verifying null checks.

The change to allow chain to be null or undefined increases flexibility. This aligns with the PR objectives and could potentially help address the stashId display issue.

To ensure robustness, let's verify that null checks for chain are in place:

#!/bin/bash
# Description: Check for null checks on 'chain' usage

# Test: Search for 'chain' usage without null checks
rg --type typescript 'chain\.' packages/extension-polkagate/src/popup/staking/solo/stake/partials/ShowValidators.tsx

---

23-23: LGTM! Consider verifying null checks.

The change to allow api to be undefined increases flexibility. This aligns with the PR objectives and could potentially help address the stashId display issue.

To ensure robustness, let's verify that null checks for api are in place:

---

Line range hint 23-33: Verify alignment with PR objectives.

The changes made in this file primarily involve type updates and a minor formatting improvement. While these changes enhance code flexibility and readability, they don't appear to directly address the stashId display issue mentioned in the PR objectives.

To ensure we're not missing any relevant changes, let's check for modifications related to stashId display:

Could you please clarify how these changes contribute to fixing the missing stashId issue on the review page? Are there additional changes in other files that address this problem more directly?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AMIRKHANEF]

would you please review the PR that I send to this PR first, after that you may want to merge it.