fix: address the issue where account menu remains open on remove profile in extension mode

[Nick-1979]

closes #1531

Summary by CodeRabbit

• New Features

  • Enhanced the ProfileMenu component to include a new closeParentMenu functionality, improving user interaction by allowing the parent menu to be closed more intuitively.
  • Simplified the Menus component by removing unnecessary props, streamlining its interface for better usability.

• Bug Fixes

  • Resolved issues related to menu state management, enhancing the overall user experience when interacting with menus.

[coderabbitai]

Walkthrough

The changes involve modifications to the FullScreenAccountMenu and ProfileMenu components, specifically in their props structure. The setAnchorEl prop has been removed from Menus, simplifying its interface. In ProfileMenu, the setUpperAnchorEl prop has been replaced with closeParentMenu, altering how the menu closing functionality is handled. These adjustments aim to improve the component's interaction and state management.

Changes

Files	Change Summary
.../FullScreenAccountMenu.tsx, .../ProfileMenu.tsx	Removed setAnchorEl from Menus; replaced setUpperAnchorEl with closeParentMenu in ProfileMenu.

Assessment against linked issues

Objective	Addressed	Explanation
Account Menu Remains Open for Removed Accounts from a Profile (1531)	✅

🐇 In a menu so bright, with changes in sight,
The anchors are gone, and the flow feels just right.
With a closeParentMenu, we tidy the space,
No more open accounts, just a smooth, happy place!
🥕✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 814af86 and e911bf7.

Files selected for processing (3)

• packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/FullScreenAccountMenu.tsx (3 hunks)
• packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (3 hunks)
• packages/extension-polkagate/src/partials/AccountMenu.tsx (1 hunks)

Additional comments not posted (4)

packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/FullScreenAccountMenu.tsx (2)

23-23: Simplified Component Interface: Removal of setAnchorEl

The removal of the setAnchorEl prop from the Menus component simplifies its interface, which is a positive change assuming the state management responsibility has been appropriately shifted elsewhere. This should make the component easier to maintain and less error-prone.

---

120-120: Improved Modularity: Replacement of setUpperAnchorEl with closeParentMenu

Replacing setUpperAnchorEl with closeParentMenu in the ProfileMenu component is a good practice as it shifts the responsibility of closing the menu to the parent component. This change enhances modularity and separation of concerns, aligning with best practices in component-based architecture.

packages/extension-polkagate/src/partials/AccountMenu.tsx (1)

138-138: Enhanced User Interaction: Addition of closeParentMenu Prop

The addition of the closeParentMenu prop to the ProfileMenu component within AccountMenu enhances the functionality by providing a direct method to manage menu visibility. This change likely improves user interaction and responsiveness of the component.

packages/extension-polkagate/src/fullscreen/homeFullScreen/partials/ProfileMenu.tsx (1)

16-16: Refactoring for Better Separation of Concerns

The changes in the ProfileMenu component, specifically the replacement of setUpperAnchorEl with closeParentMenu, reflect a significant refactoring aimed at improving the separation of concerns. This adjustment allows the parent component to handle the closing of the menu, which is a cleaner and more modular approach. The updated handleClose function now properly utilizes closeParentMenu, ensuring that the menu closure is managed externally as intended.

Also applies to: 183-200