fix: manor fixes

PolkaGate · Oct 26, 2024 · b34be93 · b34be93
1 parent dc0fbd2
commit b34be93
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 21 deletions.
diff --git a/packages/extension-polkagate/src/fullscreen/nft/components/NftList.tsx b/packages/extension-polkagate/src/fullscreen/nft/components/NftList.tsx
@@ -15,7 +15,7 @@ import Thumbnail from './Thumbnail';
 const UNAVAILABLE_HEIGHT = 320;
 const LIST_HEIGHT = innerHeight - UNAVAILABLE_HEIGHT;
 
-function NftList ({ apis, itemsDetail, nfts }: ItemsListProps): React.ReactElement {
+function NftList ({ apis, nfts }: ItemsListProps): React.ReactElement {
   const { t } = useTranslation();
 
   return (
@@ -38,7 +38,6 @@ function NftList ({ apis, itemsDetail, nfts }: ItemsListProps): React.ReactEleme
         <Thumbnail
           api={apis[nftInfo.chainName]}
           itemInformation={nftInfo}
-          itemsDetail={itemsDetail}
           key={index}
         />
       ))

diff --git a/packages/extension-polkagate/src/fullscreen/nft/utils/constants.ts b/packages/extension-polkagate/src/fullscreen/nft/utils/constants.ts
@@ -36,7 +36,6 @@ export const IPFS_GATEWAYS = [
 
 export const MAX_RETRY_ATTEMPTS = IPFS_GATEWAYS.length;
 export const INITIAL_BACKOFF_TIME = 1000; // 1 second
-export const MAX_BACKOFF_TIME = 10000; // 10 seconds
 
 export const SUPPORTED_NFT_CHAINS = {
   'Kusama Asset Hub': { name: 'kusamaassethub', prefix: 2 },

diff --git a/packages/extension-polkagate/src/fullscreen/nft/utils/types.ts b/packages/extension-polkagate/src/fullscreen/nft/utils/types.ts
@@ -6,7 +6,7 @@ import type { ApiPromise } from '@polkadot/api';
 import type { Chain } from '@polkadot/extension-chains/types';
 import type { BN } from '@polkadot/util';
 
-export interface ItemInformation {
+export interface ItemOnChainInfo {
   collectionId?: string;
   chainName: string; // polkadot, kusama or westend asset hubs
   itemId?: string;
@@ -19,6 +19,23 @@ export interface ItemInformation {
   items?: number;
 }
 
+export interface ItemMetadata {
+  animation_url?: string | null;
+  name?: string | undefined;
+  description?: string | undefined;
+  image?: string | null | undefined;
+  attributes?: Attribute[] | undefined;
+  tags?: string[] | undefined;
+  metadataLink?: string;
+  imageContentType?: string;
+  animationContentType?: string;
+  mediaUri?: string;
+}
+
+export interface ItemInformation extends ItemOnChainInfo, ItemMetadata {
+  noData?: boolean;
+}
+
 export interface FilterSectionProps {
   items: ItemInformation[] | null | undefined;
   setItemsToShow: React.Dispatch<React.SetStateAction<ItemInformation[] | null | undefined>>;
@@ -33,24 +50,10 @@ export interface CheckboxButtonProps {
 
 interface Attribute { label: string; value: string }
 
-export interface ItemMetadata {
-  animation_url?: string | null;
-  name?: string | undefined;
-  description?: string | undefined;
-  image?: string | null | undefined;
-  attributes: Attribute[] | undefined;
-  tags: string[] | undefined;
-  metadataLink: string;
-  imageContentType?: string;
-  animationContentType?: string;
-  mediaUri?: string;
-}
-
 export type ItemsDetail = Record<string, ItemMetadata | null | undefined>;
 
 export interface ThumbnailProps {
   itemInformation: ItemInformation | undefined;
-  itemsDetail: ItemsDetail;
   api: ApiPromise | undefined;
 }
 
@@ -69,7 +72,6 @@ export interface FullscreenNftModalProps {
 
 export interface DetailsProp {
   api: ApiPromise | undefined;
-  details: ItemMetadata | null;
   itemInformation: ItemInformation;
   show: boolean;
   setShowDetail: React.Dispatch<React.SetStateAction<boolean>>;
@@ -91,7 +93,6 @@ export interface DetailProp {
 
 export interface ItemsListProps {
   nfts: ItemInformation[] | null | undefined;
-  itemsDetail: ItemsDetail;
   apis: Record<string, ApiPromise | undefined>;
 }
 

diff --git a/packages/extension-polkagate/src/util/types.ts b/packages/extension-polkagate/src/util/types.ts
@@ -838,4 +838,4 @@ export interface FastestConnectionType {
 
 export type RecentChainsType = Record<string, string[]>;
 
-export type NftItemsContextType = Record<string, ItemInformation[]>;
+export type NftItemsType= Record<string, ItemInformation[]>;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -838,4 +838,4 @@ export interface FastestConnectionType {

		export type RecentChainsType = Record<string, string[]>;

		export type NftItemsContextType = Record<string, ItemInformation[]>;
		export type NftItemsType= Record<string, ItemInformation[]>;