Skip to content

Commit

Permalink
refactor: utilize React memo to decrease unneeded re-renders (#1554)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nick-1979 authored Sep 23, 2024
1 parent 103222e commit 997ea77
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export const EyeIconFullScreen = ({ isHidden, onClick }: { isHidden: boolean | u
);
};

export default function AccountInformationForDetails ({ accountAssets, address, label, price, pricesInCurrency, selectedAsset, setAssetIdOnAssetHub, setSelectedAsset }: AddressDetailsProps): React.ReactElement {
function AccountInformationForDetails ({ accountAssets, address, label, price, pricesInCurrency, selectedAsset, setAssetIdOnAssetHub, setSelectedAsset }: AddressDetailsProps): React.ReactElement {
const theme = useTheme();
const { account, api, chain, formatted, genesisHash, token } = useInfo(address);

Expand Down Expand Up @@ -284,3 +284,5 @@ export default function AccountInformationForDetails ({ accountAssets, address,
</Grid>
);
}

export default React.memo(AccountInformationForDetails);
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import ProfileTabsFullScreen from './partials/ProfileTabsFullScreen';
import TotalBalancePieChart, { type AssetsWithUiAndPrice } from './partials/TotalBalancePieChart';
import WatchList from './partials/WatchList';

export default function HomePageFullScreen (): React.ReactElement {
function HomePageFullScreen (): React.ReactElement {
useFullscreen();
const { t } = useTranslation();

Expand Down Expand Up @@ -92,3 +92,5 @@ export default function HomePageFullScreen (): React.ReactElement {
</Grid>
);
}

export default React.memo(HomePageFullScreen);
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const AccountTotal = ({ currencySign, hideNumbers, totalBalance }: { currencySig
);
};

export default function AccountInformationForHome ({ accountAssets, address, hideNumbers, isChild, selectedAsset, setSelectedAsset }: AddressDetailsProps): React.ReactElement {
function AccountInformationForHome ({ accountAssets, address, hideNumbers, isChild, selectedAsset, setSelectedAsset }: AddressDetailsProps): React.ReactElement {
const { t } = useTranslation();
const theme = useTheme();
const pricesInCurrencies = usePrices();
Expand Down Expand Up @@ -260,3 +260,5 @@ export default function AccountInformationForHome ({ accountAssets, address, hid
</>
);
}

export default React.memo(AccountInformationForHome);
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const saveNewOrder = (newOrder: AccountsOrder[]) => {
chrome.storage.local.set({ addressOrder }).catch(console.error);
};

export default function DraggableAccountList({ hideNumbers, initialAccountList }: Props) {
function DraggableAccountList ({ hideNumbers, initialAccountList }: Props) {
const [accountsOrder, setAccountsOrder] = useState<AccountsOrder[]>(initialAccountList);
const [quickActionOpen, setQuickActionOpen] = useState<string | boolean>();

Expand Down Expand Up @@ -67,3 +67,5 @@ export default function DraggableAccountList({ hideNumbers, initialAccountList }
</DndContext>
);
}

export default React.memo(DraggableAccountList);
4 changes: 3 additions & 1 deletion packages/extension-polkagate/src/popup/home/ManageHome.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import HomePageFullScreen from '../../fullscreen/homeFullScreen';
import useIsExtensionPopup from '../../hooks/useIsExtensionPopup';
import Home from '.';

export default function ManageHome (): React.ReactElement {
function ManageHome (): React.ReactElement {
const onExtension = useIsExtensionPopup();
const [home, setHome] = useState<React.ReactElement>(<></>);

Expand All @@ -21,3 +21,5 @@ export default function ManageHome (): React.ReactElement {

return (home);
}

export default React.memo(ManageHome);

0 comments on commit 997ea77

Please sign in to comment.