Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎗️ Feeless calls #431

Merged
merged 1 commit into from
Jan 16, 2025
Merged

🎗️ Feeless calls #431

merged 1 commit into from
Jan 16, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Dec 4, 2024

What?

Refund the extrinsic execution fee for calls that require a JWT

Why?

The fee payment is used to avoid spamming and stalling the chain, but all JWT calls from regular KYCs need to either pay a fee with OTM, or lock up PLMC.

And the other ones are locked behind an institutional JWT, so even if they act malicious we could check who they are and take action.

This should provide better UX, since you can say you spend 100USDT and spend 100USDT, instead of 100.03

How?

Instead of returning Ok(()) return

Ok(PostDispatchInfo{
   actual_weight: None,
   pays_fee: Pays::No,
})

Testing?

Tests don't include fee payments for extrinsics. So only way I can see to test this is creating a network with chopsticks/zombienet and trying it out ourselves.

For now it hasn't been tested, but its a simple change so should work.

Copy link
Contributor Author

JuaniRios commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios changed the title feeless calls 🎗️ Feeless calls Dec 4, 2024
@JuaniRios JuaniRios force-pushed the 12-04-feeless_calls branch from 2e8f5f4 to 1ecba7b Compare January 16, 2025 13:33
@JuaniRios JuaniRios self-assigned this Jan 16, 2025
@JuaniRios JuaniRios requested a review from lrazovic January 16, 2025 13:48
@JuaniRios JuaniRios marked this pull request as ready for review January 16, 2025 13:49
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025

Merge activity

  • Jan 16, 8:51 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 8:51 AM EST: A user merged this pull request with Graphite.

@JuaniRios JuaniRios merged commit 539a814 into main Jan 16, 2025
1 check passed
@JuaniRios JuaniRios deleted the 12-04-feeless_calls branch January 16, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants