Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add showdown type sprites #105

Merged
merged 3 commits into from
Apr 11, 2023
Merged

add showdown type sprites #105

merged 3 commits into from
Apr 11, 2023

Conversation

FallenDeity
Copy link
Contributor

Contains almost all showdown/3d model sprites that I could find with exceptions of not yet released gen 9 mons and a few pokemon backwards sprites

  • pikcachu libre back sprite normal and shiny
  • venusaur gmax
  • blastoise gmax
  • urshifu gmax both forms
  • gen 8 starter gmax forms
    iirc those should be about it.
    Another query i have would be about the different form variations of pokemons like unown, arceus, alcremie, silvally etc are those to be added or is there a slot for them.

@Naramsim
Copy link
Member

Naramsim commented Feb 5, 2023

Hi, the diff is too large and github cannot render it. Can you embed some images here so we see what they look like?

@Naramsim
Copy link
Member

Naramsim commented Feb 5, 2023

for unown, arceus, alcremie, silvally, you can check out if there's multiple pokemon (id>10000) or if there's pokemon-forms for them.

@FallenDeity
Copy link
Contributor Author

images are xy style 3d models used in showdown refrences can be found here
https://play.pokemonshowdown.com/sprites/
ani and ani-back shiny etc
@Naramsim
also the form do exist in pokeapi Pokemon endpoint under forms category should I add them like id-form.gif in the folders also all the sprites are in a showdown folder with same file structure as the gen 5 type default sprites

@Naramsim
Copy link
Member

Naramsim commented Feb 6, 2023

Ok, perfect, are those XY format or ultra sun ultra moon? I see that the two kinds are pretty similar, if not the same.

Depending on which one we think they belong to, we can put them in the appropriate-folder/animated. PS: all of those images come from ROMs? Or some of them have been created by the Smogon community?

@FallenDeity
Copy link
Contributor Author

smogon pkpariso basically sources are same a Pokemonshowdown credit list

@FallenDeity
Copy link
Contributor Author

also its 3ds style sprite that's why it's similar to xy and sm

@FallenDeity
Copy link
Contributor Author

@Naramsim any updates?

@Naramsim
Copy link
Member

Hi @FallenDeity , yes, I can't review this PR as it is now, it's too big and even checking it out locally I'm having an hard time.

Can we create a smaller one, easier to review?

I'd start from the additions:

  • pikcachu libre back sprite normal and shiny
  • venusaur gmax
  • blastoise gmax
  • urshifu gmax both forms
  • gen 8 starter gmax forms

Leaving out all showdown/3d?

@FallenDeity
Copy link
Contributor Author

Hi @FallenDeity , yes, I can't review this PR as it is now, it's too big and even checking it out locally I'm having an hard time.

Can we create a smaller one, easier to review?

I'd start from the additions:

  • pikcachu libre back sprite normal and shiny
  • venusaur gmax
  • blastoise gmax
  • urshifu gmax both forms
  • gen 8 starter gmax forms

Leaving out all showdown/3d?

the ones u mentioned like pikachu libre venusaur etc their 3ds sprites are unavailable if u want I can make updates one by one like front-default shiny and so on but it should still be easy to view changes right just clone it locally and browse with file browser if u wanna check images then just keep the thumbnail setting on. splitting this seems more work as of now.

@Naramsim
Copy link
Member

the ones u mentioned like pikachu libre venusaur etc their 3ds sprites are unavailable

I don't understand then, why in the first message you wrote those names?

@FallenDeity
Copy link
Contributor Author

the ones u mentioned like pikachu libre venusaur etc their 3ds sprites are unavailable

I don't understand then, why in the first message you wrote those names?

i wrote those as a record so that the missing gifs can be added later when its available cause if only I have it in a excel file locally or something I might accidentally delete it also if the missing ones are compiled in one place properly its easier for others to contribute as well.

@Naramsim
Copy link
Member

Naramsim commented Feb 11, 2023

Ahhh, ok, it wasn't clear. Ok.

So the changes of this PR are just the addition of the images under /pokemon/showdown?

@FallenDeity
Copy link
Contributor Author

Ahhh, ok, it wasn't clear. Ok.

So the changes of this PR are just the addition of the images under /pokemon/showdown?

yes. Also presumably changes need to be made in the api as well to include another showdown field for pokemon endpoint

@FallenDeity
Copy link
Contributor Author

any updates on this pr or should i add another commit including the forms of showdown pokemon like arceus silvally etc

@Naramsim
Copy link
Member

Hey @FallenDeity sorry I haven't come back. Right now I don't really have time. I'm traveling and have no spare time for Github. I'll take a deeper look in the next weeks. Sorryyyy

@FallenDeity
Copy link
Contributor Author

@Naramsim leave a ping or message when you do take a look though 🥺

@FallenDeity
Copy link
Contributor Author

any updates on this pr or should i add another commit including the forms of showdown pokemon like arceus silvally etc

added forms of pokemons as well as mentioned above also it would be good to receive some updates about this pr cause i personally feel this would be a pretty cool addition to the api enabling many devs to make animated games and some cool stuff

@Naramsim
Copy link
Member

Naramsim commented Apr 9, 2023

I'll try to look at it on Tuesday maybe 😆

Thanks so much for it!

@Naramsim Naramsim merged commit 31e410f into PokeAPI:master Apr 11, 2023
@Naramsim
Copy link
Member

I merged! I moved everything to the other folder. TY

@FallenDeity
Copy link
Contributor Author

aight cool 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants