Improve CACHE dir handling, use XDG standard, fix whitespace and shebang #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shebang lines are meant for executable scripts, not libraries that are imported. Libraries should not have it as it could be misleading. Besides, the recommended shebang for python is '#!/usr/bin/env python'
New default cache directory now respects XDG_CACHE_HOME, adhering to the XDG Base Directory specification as described in https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html In most systems this evaluates to ~/.cache/pokebase
|
I wanted to let you know I've seen your PR, but I currently can't take an in-depth look at the code. I certainly will when I get the time to. Overall, it looks like you've made some handy-dandy improvements, thanks very much! I intend to merge sometime soon, again, once I get the time to look through it. |
|
No problem, take your time. Soon I'll post more PRs, mostly concerning encounters and improving performance. Btw, about encounters: what do you feel about a new "subresource" to handle things like Pokemon/123/encounters ? |
|
Re: the subresource - I think I filed #10 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to use
~/.cache/pokebaseinstead of current~/.pokebase, to avoid further cluttering$HOMEwith hidden dirs. For backward-compatibility purposes if the old location already exists use it instead, so the change will affect only new installs.The other changes are mostly cosmetic and improved security when handling directory creation.