Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teal mask ability names #938

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Oct 5, 2023

Added ability names of newly introduced abilities since Teal Mask.

302,9,Toxic Chain
302,11,どくのくさり
303,1,おもかげやどし
303,9,Embody Aspect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Embody Aspect" is a unique ability of Ogerpon.

But, this ability has appeared only in Terastallize.

I think it's better to define each form of Terastalized Ogerpon.

Copy link
Member

@Naramsim Naramsim Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I merge or you need to modify something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the form data on the other PR

https://github.com/PokeAPI/pokeapi/pull/939/files#diff-1d10c8ae6d04e5f3f00c5eb3f886a7d7930c3f4d0e63456642dfa5a24fe78abfR1460-R1462

My idea is to introduce a new form like ogerpon-telastalize and its ability should be "Embody Aspect".

@giginet
Copy link
Contributor Author

giginet commented Oct 5, 2023

I added for other languages

@giginet
Copy link
Contributor Author

giginet commented Oct 5, 2023

You can merge if you approve this PR.

@Naramsim Naramsim merged commit f38122a into PokeAPI:master Oct 6, 2023
@giginet giginet deleted the teal-mask-abilities branch October 6, 2023 05:14
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants