Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing languages for PLA and SV species names #935

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add missing languages for PLA and SV species names #935

merged 1 commit into from
Oct 4, 2023

Conversation

leftmostcat
Copy link
Contributor

The current data is missing the following:

  • Spanish names for Pokémon introduced in Legends: Arceus
  • Spanish and Italian names for Pokémon introduced in Scarlet/Violet
  • All but English names for Pokémon introduced in The Teal Mask

This PR corrects each of these and ensures that all official languages are given for all Pokémon as of writing. Names are sourced from the respective species' pages on Bulbapedia.

giginet
giginet approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Japanese translation

data/v2/csv/pokemon_species_names.csv
1011,5,Pomdramour,
1011,6,Sirapfel,
1011,7,Dipplin,
1011,8,Dipplin,
1011,9,Dipplin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add language_id=11 (Japanese Kana)?

They will be identical with language_id = 1 (Japanese).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be addressed now. (Although isn't the numbering the other way around?)

giginet
giginet approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@Naramsim Naramsim merged commit c0c853c into PokeAPI:master Oct 4, 2023
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user pokeapi-machine-user mentioned this pull request Oct 4, 2023
Merged
@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Oct 4, 2023
@pokeapi-machine-user
API data update from PokeAPI/pokeapi#935 (#185)
c3885ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giginet giginet giginet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leftmostcat @pokeapi-machine-user @giginet @Naramsim