Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item_names IDs #819

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Fix item_names IDs #819

merged 2 commits into from
Jan 15, 2023

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Jan 15, 2023

I added items on #787.
However, item_names have blank items. So these IDs are different.
#787 (comment)

I fixed this issue on this PR.

@Naramsim Naramsim changed the base branch from master to staging January 15, 2023 18:31
@Naramsim Naramsim merged commit c04d5c9 into PokeAPI:staging Jan 15, 2023
@giginet giginet deleted the fix-item-names-id branch January 15, 2023 18:35
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants