Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pokemon_form info #799

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Fix pokemon_form info #799

merged 8 commits into from
Jan 13, 2023

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Dec 13, 2022

I found some issues in the Pokémon form data.

  • Some form doesn't have i18n
  • All Hisuian forms are marked as is_battle_only. However, they should be 0.

Comment on lines +1304 to +1324
10398,growlithe-hisui,hisui,10229,24,1,0,0,1,1284
10399,arcanine-hisui,hisui,10230,24,1,0,0,1,1285
10400,voltorb-hisui,hisui,10231,24,1,0,0,1,1286
10401,electrode-hisui,hisui,10232,24,1,0,0,1,1287
10402,typhlosion-hisui,hisui,10233,24,1,0,0,1,1288
10403,qwilfish-hisui,hisui,10234,24,1,0,0,1,1289
10404,sneasel-hisui,hisui,10235,24,1,0,0,1,1290
10405,samurott-hisui,hisui,10236,24,1,0,0,1,1291
10406,lilligant-hisui,hisui,10237,24,1,0,0,1,1292
10407,zorua-hisui,hisui,10238,24,1,0,0,1,1293
10408,zoroark-hisui,hisui,10239,24,1,0,0,1,1294
10409,braviary-hisui,hisui,10240,24,1,0,0,1,1295
10410,sliggoo-hisui,hisui,10241,24,1,0,0,1,1296
10411,goodra-hisui,hisui,10242,24,1,0,0,1,1297
10412,avalugg-hisui,hisui,10243,24,1,0,0,1,1298
10413,decidueye-hisui,hisui,10244,24,1,0,0,1,1299
10414,dialga-origin,origin,10245,24,1,0,0,1,1300
10415,palkia-origin,origin,10246,24,1,0,0,1,1301
10416,basculin-white-striped,white-striped,10247,24,1,0,0,1,1302
10417,basculegion-female,female,10248,24,1,0,0,1,1303
10418,enamorus-therian,therian,10249,24,1,0,0,1,1304
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_battle_only columns of Hisuian forms should be 0.

854,9,,Phony Sinistea
854,6,Fälschungsform,Fatalitee (Fälschung)
854,11,がんさくフォルム,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Japanese localization for Phony/Antique forms of Sinistea/Polteageist

@@ -2729,9 +2733,11 @@ pokemon_form_id,local_language_id,form_name,pokemon_name
10309,5,,Rubombelle Dominant
10309,6,Totemform,Totem Bandelby
10309,9,,Totem Ribombee
10310,1,,イワンコ(マイペース)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Japanese localization for Rockruff(Own Tempo).

@giginet giginet force-pushed the missing-form-info branch from 6528622 to 5b384a5 Compare January 9, 2023 06:17
@Naramsim Naramsim merged commit 571fbb1 into PokeAPI:master Jan 13, 2023
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants