Changed Scale Shot Effect Text #758
Conversation
The effect text for Scale Shot (move ID 799) was modified to be more accurate and specific, in accordance with Issue PokeAPI#749. As part of doing so, 3 files were modified: 1. move_effects.csv The new effect_id 443 was added. 2. moves.csv The effect_id of scale_shot was changed from 1 to 443. 3. move_effect_prose.csv The new effect text under the ID 443 was added.
data/v2/csv/move_effect_prose.csv
Outdated
| 7,9,Has a $effect_chance% chance to [paralyze]{mechanic:paralysis} the target.,Inflicts [regular damage]{mechanic:regular-damage}. Has a $effect_chance% chance to [paralyze]{mechanic:paralyze} the target. | ||
| 8,9,User faints.,"User [faint]{mechanic:faint}s, even if the attack [fail]{mechanic:fail}s or [miss]{mechanic:miss}es. Inflicts [regular damage]{mechanic:regular-damage}." | ||
| 9,9,Only works on sleeping Pokémon. Drains half the damage inflicted to heal the user.,[Fails]{mechanic:fail} if not used on a [sleep]{mechanic:sleep}ing Pokémon. Inflicts [regular damage]{mechanic:regular-damage}. [Drains]{mechanic:drain} half the damage inflicted to heal the user. | ||
| move_effect_id,local_language_id,short_effect,effect, |
There was a problem hiding this comment.
Hi, why did you add all the ,?
There was a problem hiding this comment.
I think it's because I edited the .csv file in Microsoft Excel and it automatically did that. I'm sorry - I should have opened it in a text editor instead and only added that so that no formatting issues like that occurred. I'll update this PR and remove the unnecessary changes.
Fixed the comma formatting error caused by editing the .csv file using Microsoft Excel instead of a text editor.
|
Thanks! |
|
A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
CONTENT
The effect text for Scale Shot (move ID 799) was modified to be more accurate and specific, in accordance with Issue #749.
As part of doing so, 3 files were modified:
move_effects.csv
The new effect_id 443 was added.
moves.csv
The effect_id of scale_shot was changed from 1 to 443.
move_effect_prose.csv
The new effect text under the ID 443 was added.
TESTING
For testing, the instructions under "Setup" and "Database setup" were followed and the API was locally hosted.
Then, a GET request was made by accessing the Scale Shot move page in my browser:
(localhost IP)/api/v2/move/scale-shot/