Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basculegion-female and enamorus-therian parenting #753

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

uwx
Copy link
Contributor

@uwx uwx commented Sep 21, 2022

basculegion-female (form) is parented to basculegion-male (pokemon) instead of basculegion-female (pokemon). This results in basculegion-female (pokemon) having no forms, and basculegion-male having both male and female as a form.

This PR changes the female form's parent pokemon ID to the female pokemon's ID.

Q: Am I doing this right?

@Naramsim
Copy link
Member

A: maybe, did you try to build it locally? If it's correct please tell me

@uwx uwx changed the title Fix basculegion-female parenting Fix basculegion-female and enamorus-therian parenting Sep 22, 2022
@uwx
Copy link
Contributor Author

uwx commented Sep 22, 2022

Tested this locally, appears to work as intended. I also noticed enamorus-therian had the same problem, being parented to enamorus-incarnate instead of enamorus-therian, so I fixed that one too.

@Naramsim Naramsim merged commit 1aea9f7 into PokeAPI:master Sep 22, 2022
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants