Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables throttling #464

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Disables throttling #464

merged 3 commits into from
Jan 26, 2020

Conversation

Naramsim
Copy link
Member

Since the entire API is now static files, we don't need anymore any throttling. This simplifies also updating data in the api-data repo.

@Kronopt
Copy link
Member

Kronopt commented Dec 17, 2019

How is this going to affect the Fair Use Policy described in the pokeapi.co documentation?

@Naramsim
Copy link
Member Author

It won't since we are not using anymore this python server to serve the APIs, we are using static hosting on Firebase.

PS: And now with firebase, there is no throttling at all.

Copy link
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well delete it? We can always get it back through git history

@Naramsim Naramsim requested a review from phalt December 18, 2019 11:59
@Naramsim
Copy link
Member Author

@phalt, can you unlock?

@Naramsim Naramsim merged commit cb413c2 into master Jan 26, 2020
@Naramsim Naramsim deleted the disable_throttling branch January 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants