Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed effect of "Scorching Sands" to indicate it causes a burn #1215

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

aserra54
Copy link
Contributor

@aserra54 aserra54 commented Mar 2, 2025

Fixes the effect text of "Scorching Sands" to indicate that it has a 30% chance to cause a burn. Previously, the API indicated it did regular damage with no additional effect.

Sample of new response:

{
  "id": 815,
  "name": "scorching-sands",
  "accuracy": 100,
  "effect_chance": 30,
  <snip>
  "effect_entries": [
    {
      "effect": "Inflicts regular damage.  Has a 30% chance to burn the target.",
      "short_effect": "Has a 30% chance to burn the target.",
      "language": {
        "name": "en",
        "url": "http://localhost/api/v2/language/9/"
      }
    }
  ],
  <snip>
}

@Naramsim Naramsim merged commit 7d62449 into PokeAPI:master Mar 2, 2025
7 checks passed
@Naramsim
Copy link
Member

Naramsim commented Mar 2, 2025

Thanks for spotting it! :)

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants