Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Added flavor texts from SV to all abilities #1021

Merged
merged 3 commits into from
Jan 25, 2024
Merged

DRAFT: Added flavor texts from SV to all abilities #1021

merged 3 commits into from
Jan 25, 2024

Conversation

erezushi
Copy link
Contributor

Changes:

  • Ability flavor texts from SV to all abilities available in the games, given to the version group in which it was first released (text copied from Bulbapedia)
  • Fixed bad character in the word 'Pokémon' in some of the Teal Mask abilities

Marked as draft because I have a few questions:

  • A lot of the descriptions had line breaks in them, should I put them in the ones I added and where? (Even a rule of thumb would help)
  • Should quotes only surround texts with either a newline or a comma in them?
  • I put Misty Terrain with the base SV version group, but the only Pokémon that had it is the Fairy Starmobile, and a proper Pokémon with it only came out in the Teal Mask, is that fine?
  • I couldn't add the description for Embody Aspect as it is in the same situation of As One, where the different forms of the Pokémon have slightly different effects, but even though As One is separated in the API, Embody Aspect isn't, and I think it creates a mismatch between game indexes and API indexes. Is it too late to fix it now?

@erezushi erezushi marked this pull request as draft January 24, 2024 22:09
@Naramsim
Copy link
Member

Naramsim commented Jan 25, 2024

Thanks a lot! We are really glad whenever we have a new contributor!

  • A lot of the descriptions had line breaks in them, should I put them in the ones I added and where? (Even a rule of thumb would help)

No need to add any line break. We have those linebrakes since the strings come directly from the ROMs.

  • Should quotes only surround texts with either a newline or a comma in them?

They should surround strings containing ,.

  • I put Misty Terrain with the base SV version group, but the only Pokémon that had it is the Fairy Starmobile, and a proper Pokémon with it only came out in the Teal Mask, is that fine?

it's fine.

  • I couldn't add the description for Embody Aspect as it is in the same situation of As One, where the different forms of the Pokémon have slightly different effects, but even though As One is separated in the API, Embody Aspect isn't, and I think it creates a mismatch between game indexes and API indexes. Is it too late to fix it now?

I think it's better to treat as As One and create all the other abilities. As of now you can add a generic description such as The Pokémon's heart fills with memories, causing the Mask to shine and a Pokémon's stat to be boosted.

@erezushi
Copy link
Contributor Author

Right, I added the generic description, and removed the quotes where there are no commas

@erezushi erezushi marked this pull request as ready for review January 25, 2024 18:05
@Naramsim Naramsim merged commit 247abb8 into PokeAPI:master Jan 25, 2024
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants