Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle CI deploy only master #35

Merged
merged 4 commits into from
Apr 26, 2020
Merged

Circle CI deploy only master #35

merged 4 commits into from
Apr 26, 2020

Conversation

Naramsim
Copy link
Member

Allows triggering deployments only when the master branch gets pushed

@Naramsim Naramsim requested review from Kronopt and a team April 26, 2020 14:54
cmmartti
cmmartti approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@cmmartti cmmartti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you test that it works?

@Naramsim
Copy link
Member Author

Looks good to me. Did you test that it works?

I didn't test it but that's how the documentation shows. Anyway, we will see right now 😄.

@Naramsim Naramsim merged commit dd54d13 into master Apr 26, 2020
@Naramsim Naramsim deleted the circle-ci-deploy branch April 26, 2020 16:46
@Naramsim
Copy link
Member Author

Ok, it turns out that artifacts are attached to individual jobs and not to projects. So by using the latest tag, we are fetching the artifacts of the deploy job which does not produce any of them.

Instead, it is the build job that produces the artifacts.

So I suggest to merge the build and deploy phase

@Naramsim
Copy link
Member Author

Naramsim commented Apr 26, 2020 •
edited
Loading

Ok, so they are deployed if the store_artifacts command is part of the last job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmmartti cmmartti cmmartti approved these changes

@Kronopt Kronopt Awaiting requested review from Kronopt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naramsim @cmmartti