MovingLeastSquares: reduce the number of instantiations to reduce com… #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pile time PCL_XYZ_POINT_TYPES currently contains 18 types, so previously, MLS was instantiated for 18*18=324 different type combinations. However, among those were instantiations which are likely used by nobody (like `pcl::MovingLeastSquares<pcl::PointWithRange, pcl::PointDEM>`). With these changes, MLS is only instantiated 6*6+(18-6)=48 times. The most common type combinations should be covered, but if someone uses an uncommon combinations, they have to add `#define PCL_NO_PRECOMPILE` before including `pcl/surface/mls.h` to avoid linker errors.
mvieth
added
changelog: enhancement
larshg
approved these changes
Jul 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pile time
PCL_XYZ_POINT_TYPES currently contains 18 types, so previously, MLS was instantiated for 18x18=324 different type combinations. However, among those were instantiations which are likely used by nobody (like
pcl::MovingLeastSquares<pcl::PointWithRange, pcl::PointDEM>). With these changes, MLS is only instantiated 6x6+(18-6)=48 times. The most common type combinations should be covered, but if someone uses an uncommon combination, they have to add#define PCL_NO_PRECOMPILEbefore includingpcl/surface/mls.hto avoid linker errors.See also #3414