Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code, tests and tutorials for RoPS and MomentOfInertia features #319

Merged
merged 9 commits into from
Dec 14, 2013

Conversation

GooseSergey
Copy link
Contributor

Code, tests and tutorials for RoPS and MomentOfInertia features

@jspricke
Copy link
Member

Hi @GooseSergey, thanks for the contribution. Could you please fix compile error Travis found? Thansk!

@GooseSergey
Copy link
Contributor Author

GooseSergey commented Oct 31, 2013 via email

@jspricke
Copy link
Member

HI Sergey,
on the server we are compiling with PCL_ONLY_CORE_POINT_TYPES set, that's why you don't get get the error locally. The point there is to compile the class only for certain point types and not all we have, to speed up compilation. If you know that your feature is only commonly only used with some of the point types, you can limit them (note, you probably want PCL_INSTANTIATE_PRODUCT in 8f37499).

@GooseSergey
Copy link
Contributor Author

Hi Jochen.

Thank you for explaining. Now I understand why it was built successfully on my pc.

note, you probably want PCL_INSTANTIATE_PRODUCT in 8f37499
No, the class we instantiate has only one template parameter.

Are there still some errors on Travis?

Sergey

@jspricke
Copy link
Member

jspricke commented Nov 8, 2013

@GooseSergey it's still failing, you can check that yourself on the pull request site (there is a red cross next to the last commit id). Also, I think you should get a mail from Travis, don't you?

@GooseSergey
Copy link
Contributor Author

Thank you for help. I think I fixed it. My code seems to compile and link properly.
The only thing is that I get the "time exceeded" error while building.

Also, I think you should get a mail from Travis, don't you?

No, I don't get any mail notices from Travis.

rbrusu added a commit that referenced this pull request Dec 14, 2013
Code, tests and tutorials for RoPS and MomentOfInertia features
@rbrusu rbrusu merged commit e7740a8 into PointCloudLibrary:master Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants