Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access specifier in PointCloudColorHandlerRGBAField #2226

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

UnaNancyOwen
Copy link
Member

@UnaNancyOwen UnaNancyOwen commented Feb 23, 2018

Fix access specifier in PointCloudColorHandlerRGBAField.
I think that members derived from the base class should be private in this class.
(See PointCloudColorHandlerRGBField a similar class.)

  • PointCloudColorHandlerRGBField

    protected:
    /** \brief Class getName method. */
    virtual std::string
    getName () const { return ("PointCloudColorHandlerRGBField"); }
    private:
    // Members derived from the base class
    using PointCloudColorHandler<PointT>::cloud_;
    using PointCloudColorHandler<PointT>::capable_;
    using PointCloudColorHandler<PointT>::field_idx_;
    using PointCloudColorHandler<PointT>::fields_;
    };

  • PointCloudColorHandlerRGBAField

    protected:
    /** \brief Class getName method. */
    virtual std::string
    getName () const { return ("PointCloudColorHandlerRGBAField"); }
    // Members derived from the base class
    using PointCloudColorHandler<PointT>::cloud_;
    using PointCloudColorHandler<PointT>::capable_;
    using PointCloudColorHandler<PointT>::field_idx_;
    using PointCloudColorHandler<PointT>::fields_;
    };

Fix access specifier in PointCloudColorHandlerRGBAField.
Members derived from the base class is private.
@SergioRAgostinho SergioRAgostinho merged commit 120afdc into PointCloudLibrary:master Feb 25, 2018
@SergioRAgostinho SergioRAgostinho added the changelog: API break Meta-information for changelog generation label Aug 26, 2018
@SergioRAgostinho SergioRAgostinho changed the title Fix access specifier in PointCloudColorHandlerRGBAField Fix access specifier in PointCloudColorHandlerRGBAField Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: API break Meta-information for changelog generation module: visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants