OpenNI2Device Add device sensor check for IR and depth modesetting
#2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re IR and depth modesetting
|
Can you |
SergioRAgostinho
approved these changes
Dec 15, 2017
|
On Travis we don't have OpenNI2 anyway, so we don't need to see CI results. |
taketwo
approved these changes
Dec 15, 2017
Closed
SergioRAgostinho
changed the title
OpenNI2Device Add device sensor check for IR and depth modesetting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1348, tested with release 1.8.1 and latest master on Gentoo Linux, VTK-6.1.0 and VTK-7.1.0, OpenNI-2.2.0.33, latest libfreenect.
While it won't crash program should device lack IR and depth sensors, there is some peculiar stuff going on with threads; random crashes seem to appear upon startup.