Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in renderViewTesselatedSphere #1043

Merged
merged 1 commit into from
Dec 15, 2014

Conversation

Tonsty
Copy link
Contributor

@Tonsty Tonsty commented Dec 15, 2014

Loopsubdivision will not guarantee new vertices stay on unit sphere,
so we should normalize the coordinates.

@VictorLamoine
Copy link
Contributor

Hello, can you fix this as well please?
From what I understood It's just adding subdivide->Update ();

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

Ok

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

@VictorLamoine , I have checked the code, but I found subdivide->Update (); is already added there.

@VictorLamoine
Copy link
Contributor

Oh that's right! The user on the mailing list must be using an old PCL version.

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

Yes, so will you merge this request?

@taketwo
Copy link
Member

taketwo commented Dec 15, 2014

@Tonsty yes as soon as you fix the things that Jochen pointed out.

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

@taketwo, sorry, "Jochen"? I don't know him. Please give me a link.

@jspricke
Copy link
Member

@Tonsty That's me, you need to fix your indenting (2 spaces per indention).

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

@jspricke Ah, sorry. I forgot to tell you, I have fixed it, you can look at code, 2 spaces have been added.

@taketwo
Copy link
Member

taketwo commented Dec 15, 2014

Sorry, but there are tabs still in your code.

@jspricke
Copy link
Member

No, it should be only spaces (two per indention level). Basically just the same as the previous line.

@Tonsty
Copy link
Contributor Author

Tonsty commented Dec 15, 2014

Oh, I see. I'll fixed it now. By the way, I wonder which text editor you use to write code? Vim or Emacs or Eclipse or Sublime?

Loopsubdivision will not guarantee new vertices stay on unit sphere,
so we should normalize the coordinates.
@taketwo
Copy link
Member

taketwo commented Dec 15, 2014

Thanks!

I'm a Vim user.

taketwo added a commit that referenced this pull request Dec 15, 2014
Fix bug in renderViewTesselatedSphere
@taketwo taketwo merged commit e0b3ea8 into PointCloudLibrary:master Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants