-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in renderViewTesselatedSphere #1043
Conversation
Hello, can you fix this as well please? |
Ok |
@VictorLamoine , I have checked the code, but I found |
Oh that's right! The user on the mailing list must be using an old PCL version. |
Yes, so will you merge this request? |
@Tonsty yes as soon as you fix the things that Jochen pointed out. |
@taketwo, sorry, "Jochen"? I don't know him. Please give me a link. |
@Tonsty That's me, you need to fix your indenting (2 spaces per indention). |
@jspricke Ah, sorry. I forgot to tell you, I have fixed it, you can look at code, 2 spaces have been added. |
Sorry, but there are tabs still in your code. |
No, it should be only spaces (two per indention level). Basically just the same as the previous line. |
Oh, I see. I'll fixed it now. By the way, I wonder which text editor you use to write code? Vim or Emacs or Eclipse or Sublime? |
Loopsubdivision will not guarantee new vertices stay on unit sphere, so we should normalize the coordinates.
Thanks! I'm a Vim user. |
Fix bug in renderViewTesselatedSphere
Loopsubdivision will not guarantee new vertices stay on unit sphere,
so we should normalize the coordinates.