🐛 Fix the PR cover checker when there is no test #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that is workflow failure when the pull request does not contain tests
adds a validation to verify that Pull Request files are testable
This commit changes the check to validate if there was no test because it didn't test it or if it's because the PR files are not testable
DouglasCorreiaMeli
force-pushed
the
fix/pull_request_coverage
branch
from
f6c28db to
e09bc34
Compare
maicongouveia
previously approved these changes
Nov 4, 2021
lira
previously approved these changes
Nov 4, 2021
GiovanniCavallari
previously approved these changes
Nov 4, 2021
DouglasCorreiaMeli
dismissed stale reviews from GiovanniCavallari, lira, and maicongouveia
via
2178fb6
DouglasCorreiaMeli
changed the title
DouglasCorreiaMeli
force-pushed
the
fix/pull_request_coverage
branch
from
ca2fc27 to
3ea2fb1
Compare
GiovanniCavallari
changed the title
lira
approved these changes
Nov 9, 2021
luiztucillo
approved these changes
Nov 10, 2021
lira
added a commit
that referenced
this pull request
Nov 16, 2021
* 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: Douglas <[email protected]>
lira
added a commit
that referenced
this pull request
Dec 3, 2021
* feat(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * added payment places method * comments removed * refactored access token validation * fixed ternary if structure * fixed instantiation of access token * 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * feat(PPWP-421): paycash front-end * feat(PPWP-422): paycash admin * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * improv: init tests * improv: changing chmod command * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 * getMercadoPagoPaymentMethods testing * fix(ppwp-337): fixing exception testing * testing config provider and api * testing PaymentMethodsTicket * feat(ppwp-377): testing custom config provider * refactored constants * refactored model test classes * refactored helper test classes * added annotation for Code Coverage Ignore * fixed test variables * fixed html structure of ticket * feat(ppwp-377): adding metadata payment_option_id * fixing data tests * removed exception to access token * hotfix(PLUG-1533): fixing refund error handling * fixing pr coverage checker * testing pr coverage checker * fixing pr coverage checker * hotfix: fixed js - undefined variable * build: 📦 new minor version of mercardo pago for magento 2 v3.13.0 * build(v3.13.0): 📦 updated readme Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: sleaof <[email protected]> Co-authored-by: Douglas <[email protected]>
lira
added a commit
that referenced
this pull request
Jan 11, 2022
* feat(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * added payment places method * comments removed * refactored access token validation * fixed ternary if structure * fixed instantiation of access token * 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * feat(PPWP-421): paycash front-end * feat(PPWP-422): paycash admin * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * improv: init tests * improv: changing chmod command * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 * getMercadoPagoPaymentMethods testing * fix(ppwp-337): fixing exception testing * testing config provider and api * testing PaymentMethodsTicket * feat(ppwp-377): testing custom config provider * refactored constants * refactored model test classes * refactored helper test classes * added annotation for Code Coverage Ignore * fixed test variables * fixed html structure of ticket * feat(ppwp-377): adding metadata payment_option_id * fixing data tests * removed exception to access token * hotfix(PLUG-1533): fixing refund error handling * fixing pr coverage checker * testing pr coverage checker * fixing pr coverage checker * hotfix: fixed js - undefined variable * feat(PPWP-569): initial commit * build: 📦 new minor version of mercardo pago for magento 2 v3.13.0 * build(v3.13.0): 📦 updated readme * expiration date mask and validations * PPWP-569: inserted translations for titles * PPWP-569: added space between fields * improv(PPWP-611): dinamically validating bank transfer on admin page * implementing cache * PPWP-611: payment unit tests * PPWP-611: fixed abstractElementMock * fix(wallet button): 🐛 create order even with cho pro disabled * fixing cache * separating cache values with constants * PPWP-611: refactored test directory * PPWP-570: added translation * PPWP-569: inserted style in title * PPWP-569: fixed cache for new installs * PPWP-569: fixed cache for new installs * feature(ppwp-630): new front-end definitions * removing cache from bank_transfer validation * fixing payment fieldset and removing debit text * improv(ppwp-531): adding mlu to available lists * adding payment methods validation using API * removing old validation * improving cache and applying rules to other checkouts * fixing pix rules * disabling invalid payments * clearing config activation flag caching * testing new methods * fixing cache code coverage * fixing observer code coverage * fixing exception syntax * code enhancement * fixing prefix issue * fix(ticket): 🐛 changed str_contains to strpos * build(v3.14.0): 📦 updated version files and changelog * build(v3.14.0): 📦 updated changelog * fix: treating paymentId on disablePayment function Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: sleaof <[email protected]> Co-authored-by: Douglas <[email protected]>
lira
added a commit
that referenced
this pull request
Jan 11, 2022
* feat(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * added payment places method * comments removed * refactored access token validation * fixed ternary if structure * fixed instantiation of access token * 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * feat(PPWP-421): paycash front-end * feat(PPWP-422): paycash admin * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * improv: init tests * improv: changing chmod command * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 * getMercadoPagoPaymentMethods testing * fix(ppwp-337): fixing exception testing * testing config provider and api * testing PaymentMethodsTicket * feat(ppwp-377): testing custom config provider * refactored constants * refactored model test classes * refactored helper test classes * added annotation for Code Coverage Ignore * fixed test variables * fixed html structure of ticket * feat(ppwp-377): adding metadata payment_option_id * fixing data tests * removed exception to access token * hotfix(PLUG-1533): fixing refund error handling * fixing pr coverage checker * testing pr coverage checker * fixing pr coverage checker * hotfix: fixed js - undefined variable * feat(PPWP-569): initial commit * build: 📦 new minor version of mercardo pago for magento 2 v3.13.0 * build(v3.13.0): 📦 updated readme * expiration date mask and validations * PPWP-569: inserted translations for titles * PPWP-569: added space between fields * improv(PPWP-611): dinamically validating bank transfer on admin page * implementing cache * PPWP-611: payment unit tests * PPWP-611: fixed abstractElementMock * fix(wallet button): 🐛 create order even with cho pro disabled * fixing cache * separating cache values with constants * PPWP-611: refactored test directory * PPWP-570: added translation * PPWP-569: inserted style in title * PPWP-569: fixed cache for new installs * PPWP-569: fixed cache for new installs * feature(ppwp-630): new front-end definitions * removing cache from bank_transfer validation * fixing payment fieldset and removing debit text * improv(ppwp-531): adding mlu to available lists * adding payment methods validation using API * removing old validation * improving cache and applying rules to other checkouts * fixing pix rules * disabling invalid payments * clearing config activation flag caching * testing new methods * fixing cache code coverage * fixing observer code coverage * fixing exception syntax * code enhancement * fixing prefix issue * fix(ticket): 🐛 changed str_contains to strpos * build(v3.14.0): 📦 updated version files and changelog * build(v3.14.0): 📦 updated changelog * fix: treating paymentId on disablePayment function * Upgrade New Logo MP Magento 2 * hotfix: prevent "missing required argument $data" exception (#187) Co-authored-by: Ivan Augusto <[email protected]> * build(v3.14.1): 📦 new version v3.14.1 * build(v3.14.1): 📦 updated mercado pago's minilogo image Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: sleaof <[email protected]> Co-authored-by: Douglas <[email protected]> Co-authored-by: hugodamm <[email protected]> Co-authored-by: Code Slicer <[email protected]> Co-authored-by: Ivan Augusto <[email protected]> Co-authored-by: Hugo Damm <[email protected]>
lira
added a commit
that referenced
this pull request
Jan 28, 2022
* feat(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * added payment places method * comments removed * refactored access token validation * fixed ternary if structure * fixed instantiation of access token * 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * feat(PPWP-421): paycash front-end * feat(PPWP-422): paycash admin * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * improv: init tests * improv: changing chmod command * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 * getMercadoPagoPaymentMethods testing * fix(ppwp-337): fixing exception testing * testing config provider and api * testing PaymentMethodsTicket * feat(ppwp-377): testing custom config provider * refactored constants * refactored model test classes * refactored helper test classes * added annotation for Code Coverage Ignore * fixed test variables * fixed html structure of ticket * feat(ppwp-377): adding metadata payment_option_id * fixing data tests * removed exception to access token * hotfix(PLUG-1533): fixing refund error handling * fixing pr coverage checker * testing pr coverage checker * fixing pr coverage checker * hotfix: fixed js - undefined variable * feat(PPWP-569): initial commit * build: 📦 new minor version of mercardo pago for magento 2 v3.13.0 * build(v3.13.0): 📦 updated readme * expiration date mask and validations * PPWP-569: inserted translations for titles * PPWP-569: added space between fields * improv(PPWP-611): dinamically validating bank transfer on admin page * implementing cache * PPWP-611: payment unit tests * PPWP-611: fixed abstractElementMock * fix(wallet button): 🐛 create order even with cho pro disabled * fixing cache * separating cache values with constants * PPWP-611: refactored test directory * PPWP-570: added translation * PPWP-569: inserted style in title * PPWP-569: fixed cache for new installs * PPWP-569: fixed cache for new installs * feature(ppwp-630): new front-end definitions * removing cache from bank_transfer validation * fixing payment fieldset and removing debit text * improv(ppwp-531): adding mlu to available lists * adding payment methods validation using API * removing old validation * improving cache and applying rules to other checkouts * fixing pix rules * disabling invalid payments * clearing config activation flag caching * testing new methods * fixing cache code coverage * fixing observer code coverage * fixing exception syntax * code enhancement * fixing prefix issue * fix(ticket): 🐛 changed str_contains to strpos * build(v3.14.0): 📦 updated version files and changelog * build(v3.14.0): 📦 updated changelog * fix: treating paymentId on disablePayment function * Upgrade New Logo MP Magento 2 * hotfix: prevent "missing required argument $data" exception (#187) Co-authored-by: Ivan Augusto <[email protected]> * build(v3.14.1): 📦 new version v3.14.1 * build(v3.14.1): 📦 updated mercado pago's minilogo image * build(v3.14.2): 📦 Create a new version * build(v3.14.2): 📦 Migrate to db_schema * build(v3.14.2): 📦 link img desktop logo mercado pago * build(v3.14.2): 📦 add release to skipped branch * build(v3.14.2): 📦 add parameters :P Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: sleaof <[email protected]> Co-authored-by: Douglas <[email protected]> Co-authored-by: hugodamm <[email protected]> Co-authored-by: Code Slicer <[email protected]> Co-authored-by: Ivan Augusto <[email protected]> Co-authored-by: Hugo Damm <[email protected]>
lira
added a commit
that referenced
this pull request
Mar 22, 2022
* feat(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * fix(PPWP-377): unified calls * added payment places method * comments removed * refactored access token validation * fixed ternary if structure * fixed instantiation of access token * 🐛 Fix the PR cover checker when there is no test (#189) This fixes an issue that is workflow failure when the pull request does not contain tests and Added hotfix branch filter to check tests * feat(PPWP-421): paycash front-end * feat(PPWP-422): paycash admin * fix(helper): 🐛 fixed float to int convertion * feat(bin): ✨ new command sync with container * improv: init tests * improv: changing chmod command * build: 📦 new patch version of mercardo pago for magento 2 v3.12.3 * getMercadoPagoPaymentMethods testing * fix(ppwp-337): fixing exception testing * testing config provider and api * testing PaymentMethodsTicket * feat(ppwp-377): testing custom config provider * refactored constants * refactored model test classes * refactored helper test classes * added annotation for Code Coverage Ignore * fixed test variables * fixed html structure of ticket * feat(ppwp-377): adding metadata payment_option_id * fixing data tests * removed exception to access token * hotfix(PLUG-1533): fixing refund error handling * fixing pr coverage checker * testing pr coverage checker * fixing pr coverage checker * hotfix: fixed js - undefined variable * feat(PPWP-569): initial commit * build: 📦 new minor version of mercardo pago for magento 2 v3.13.0 * build(v3.13.0): 📦 updated readme * expiration date mask and validations * PPWP-569: inserted translations for titles * PPWP-569: added space between fields * improv(PPWP-611): dinamically validating bank transfer on admin page * implementing cache * PPWP-611: payment unit tests * PPWP-611: fixed abstractElementMock * fix(wallet button): 🐛 create order even with cho pro disabled * fixing cache * separating cache values with constants * PPWP-611: refactored test directory * PPWP-570: added translation * PPWP-569: inserted style in title * PPWP-569: fixed cache for new installs * PPWP-569: fixed cache for new installs * feature(ppwp-630): new front-end definitions * removing cache from bank_transfer validation * fixing payment fieldset and removing debit text * Update ConfigObserver.php (#183) Changing protocol for banners to use https * Fix refund: cuando el response de la API de MP es un {status:400,response:{error:bad_request,status:400}}, no se tiene que generar el creditmemo (#180) Co-authored-by: Fernando Lira <[email protected]> * improv(ppwp-531): adding mlu to available lists * adding payment methods validation using API * removing old validation * improving cache and applying rules to other checkouts * fixing pix rules * disabling invalid payments * clearing config activation flag caching * testing new methods * fixing cache code coverage * fixing observer code coverage * fixing exception syntax * code enhancement * fixing prefix issue * fix(ticket): 🐛 changed str_contains to strpos * build(v3.14.0): 📦 updated version files and changelog * build(v3.14.0): 📦 updated changelog * fix: treating paymentId on disablePayment function * Upgrade New Logo MP Magento 2 * hotfix: prevent "missing required argument $data" exception (#187) Co-authored-by: Ivan Augusto <[email protected]> * build(v3.14.1): 📦 new version v3.14.1 * build(v3.14.1): 📦 updated mercado pago's minilogo image * build(v3.14.2): 📦 Create a new version * build(v3.14.2): 📦 Migrate to db_schema * build(v3.14.2): 📦 link img desktop logo mercado pago * build(v3.14.2): 📦 add release to skipped branch * build(v3.14.2): 📦 add parameters :P * hotfix(PLUG-1713): treating invalid credentials * changing test files * set observers as no has converage * Adjusted logos from checkouts (#219) * build(v3.14.1): 📦 new version v3.14.1 * build(v3.14.1): 📦 updated mercado pago's minilogo image * build(v3.14.2): 📦 Create a new version * build(v3.14.2): 📦 Migrate to db_schema * build(v3.14.2): 📦 link img desktop logo mercado pago * build(v3.14.2): 📦 add release to skipped branch * build(v3.14.2): 📦 add parameters :P * feat: update logos from cho pro * feat: update logos from cho ticket * feat: update logos from cho custom * feat: fix credit card js * fix: fixed create payments with issuer Co-authored-by: Fernando Lira <[email protected]> Co-authored-by: Fernando Lira <[email protected]> * Fixed sending email for new order in pending status * Changed position of additional information method * Code centered in only one method * hotfix: link ticket options labels to they checkboxes (#190) Co-authored-by: Ivan Augusto <[email protected]> Co-authored-by: Fernando Lira <[email protected]> * Added cvv validation for cho custom (#222) * feat: added cvv validation for cho custom * feat: added cvv validation for cho custom * Fixed some accentuation in pt_BR translations * feat: cho ticket logo adjustments (#223) * Fixed some other accentuation in pt_BR translations and 'partually' in label * Fixed title text * Fixed text * Returning removed text pt-br (número) * build(v3.15.0): 📦 new version Co-authored-by: Gustavo Brito <[email protected]> Co-authored-by: sleaof <[email protected]> Co-authored-by: Douglas <[email protected]> Co-authored-by: Manuel Eduardo Cánepa Cihuelo <[email protected]> Co-authored-by: lc-mayoul <[email protected]> Co-authored-by: hugodamm <[email protected]> Co-authored-by: Code Slicer <[email protected]> Co-authored-by: Ivan Augusto <[email protected]> Co-authored-by: Hugo Damm <[email protected]> Co-authored-by: Giovanni Cavallari <[email protected]> Co-authored-by: katelucena-meli <[email protected]> Co-authored-by: AlberAlmeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that is workflow failure when the pull request does not contain tests.
adds whitelist of untestable files. so if the request has zero tests, it is validated: