Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api fixes #29

Merged
merged 25 commits into from
Dec 5, 2023
Merged

Api fixes #29

merged 25 commits into from
Dec 5, 2023

Conversation

dsudit01
Copy link
Collaborator

Describe your changes

A good description of what you're adding to the codebase and why

Issue ticket number and link

Ticket ENG-XXX

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have added a good description to this PR
  • I have linked the ticket to this PR

@dsudit01
logos for tokens and pairs, testnet support
52c4e54
@dsudit01
add access control header to all responses
a6c7c95
@dsudit01
add hashnote testnet sydc
612968a
@dsudit01
return logo with lp tokens
5ae5a1a
@dsudit01
add nqe
e5dc998
@dsudit01
use price oracle contract for prices, not router
56d11dd
@dsudit01
correct oracle address
4ecdc05
@dsudit01
generalize all returns to be in the same format for easy front end use
3e323ec
@dsudit01
add underlying total supply to calls
3a48c95
@dsudit01
restart container on failure
ba91ebd
@dsudit01
add http request to get proposal content
29e8359
@dsudit01
add sdyc and new price oracle
77ecf35
@dsudit01
USYC logo
4a46324
@dsudit01
remove hashnote from token name
c623eed
@dsudit01
LP token names
01cc394
@dsudit01
docker compose expose port
8f84c5d
@dsudit01
lp tokens
392a9c5
@dsudit01
redis password
1b5140c
@dsudit01
reset mc instance on backup rpc use
7cebe05
@dsudit01
get current vote tally and add string description of proposal
c943d2d
@dsudit01
removed http query, correct title and description from proposal speci…
e3c37ae 
…fic metadata
@dsudit01
add fortunify tBills to fpi
139fec5
@dsudit01
fbill svg
be0cff4
@dsudit01
new addresses for tBills
784772a
@dsudit01
new price oracle address
ba8e234
@tkkwon1998 tkkwon1998 self-requested a review December 5, 2023 19:41
tkkwon1998
tkkwon1998 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@tkkwon1998 tkkwon1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tkkwon1998 tkkwon1998 marked this pull request as ready for review December 5, 2023 19:42
@tkkwon1998 tkkwon1998 merged commit 494434e into main Dec 5, 2023
@tkkwon1998 tkkwon1998 deleted the api-fixes branch December 5, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkkwon1998 tkkwon1998 tkkwon1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsudit01 @tkkwon1998