module embedded aerospike enterprise #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matveym
reviewed
Jan 11, 2024
matveym
reviewed
Jan 11, 2024
matveym
reviewed
Jan 11, 2024
...tika/testcontainers/aerospike/enterprise/SetupEnterpriseAerospikeBootstrapConfiguration.java
Show resolved
Hide resolved
wolfchkov
force-pushed
the
feature/embedded-aerospike-enterprise
branch
from
6857e19 to
68f2699
Compare
matveym
reviewed
Jan 12, 2024
matveym
reviewed
Jan 12, 2024
| * `embedded.aerospike.reuseContainer` `(true|false, default is 'false')` | ||
| * `embedded.aerospike.dockerImage` `(default is set to 'aerospike/aerospike-server-enterprise:6.3.0.16_1')` | ||
| ** Aerospike Enterprise version must be not less then 6.3.0 | ||
| * `embedded.aerospike.featureKey` `(base64 of a feature-key-file https://aerospike.com/docs/server/operations/configure/feature-key, default is null), required for EE, |
There was a problem hiding this comment.
Probably need to add a warning about the evaluation license's limitation.
matveym
reviewed
Jan 12, 2024
|
|
||
| See `embedded-aerospike` module readme for examples. | ||
|
|
||
| ==== Disallow non-durable deletes |
There was a problem hiding this comment.
Should be part of a section "Enterprise features"
matveym
reviewed
Jan 12, 2024
| <AppenderRef ref="Console"/> | ||
| </Root> | ||
| </Loggers> | ||
| </Configuration> |
There was a problem hiding this comment.
Add new line at EOF (can set option to do this automatically in IntelliJ IDEA)
matveym
reviewed
Jan 12, 2024
| @@ -21,7 +21,7 @@ ToxiProxy is a great tool for simulating network conditions, meaning that you ca | |||
| * `embedded.aerospike.reuseContainer` `(true|false, default is 'false')` | |||
| * `embedded.aerospike.dockerImage` `(default is set to 'aerospike:ce-6.2.0.2')` | |||
| ** You can pick wanted version on https://hub.docker.com/r/library/aerospike/tags/[dockerhub] | |||
| * `embedded.aerospike.featureKey` `(base64 of a feature-key-file https://docs.aerospike.com/docs/reference/configuration/index.html#feature-key-file, default is null) is only required for the EE image` | |||
| * `embedded.aerospike.featureKey` `(base64 of a feature-key-file https://aerospike.com/docs/server/operations/configure/feature-key, default is null) is only required for the EE image` | |||
There was a problem hiding this comment.
not required anymore, need to add warning about trial license limitations
wolfchkov
force-pushed
the
feature/embedded-aerospike-enterprise
branch
2 times, most recently
from
626cf82 to
f04253d
Compare
matveym
previously approved these changes
Jan 12, 2024
…atory durable deletes by default
wolfchkov
force-pushed
the
feature/embedded-aerospike-enterprise
branch
from
f04253d to
75e6745
Compare
|
@wolfchkov Please porting this changes to Branches (support/3.0.X and support/2.3.X) |
Fameing
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added module embedded aerospike enterprise with configured mandatory durable deletes by default