Use "DCCFPS" metadata to set TCPS value in alembic reader code #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo, use that value as the TimeCodesPerSecond value of the equivalent USD data. This prevents unintended time scaling of Alembic files when translating them from Alembic (which stores samples times in seconds) into USD (which stores sample times in samples).
|
Filed as internal issue #USD-9290 |
|
Hi Mark! Could you add a small abc file that has DCCFPS set to 30 or anything other than 24? Then we can add a small test that opens the abc file and verifies that its timeCodesPerSecond matches. |
|
Of course... This file has the DCC FPS value set to 30 (generated by an as-yet-unreleased version of Houdini - shipping builds of Houdini don't author this metadata): |
|
Awesome, thank you! |
|
Hi Mark! We want to check your test file in to source control on our end, but the file provided is larger than our other test files. Would it be possible for you to provide a file with less data or only metadata that we could use in its place? |
|
Sorry this took so long... |
|
That's perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
If an alembic file has authored the "DCCFPS" metadata in its config info, use that value as the TimeCodesPerSecond value of the equivalent USD data. This prevents unintended time scaling of Alembic files when translating them from Alembic (which stores samples times in seconds) into USD (which stores sample times in samples). This change does not remove support for the old "Usd" metadata section, which takes precedence to avoid unnecessary behavior changes, and change only takes effect if building against Alembic 1.7.12 or later (when DCCFPS was introduced).
Fixes Issue(s)
Use dccFps in UsdAbc for Alembic 1.7.12 and above #1023
[ X ] I have verified that all unit tests pass with the proposed changes
[ X ] I have submitted a signed Contributor License Agreement