Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tekton via cloud event #67

Merged
merged 26 commits into from
Feb 22, 2024
Merged

feat: support tekton via cloud event #67

merged 26 commits into from
Feb 22, 2024

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Jan 5, 2024 •
edited
Loading

Why:

  • support trigger tekton as backend pipeline

How:

  • add a field: pipelineEngine to select backend pipeline, when it is set to tekton, it will trigger tekton
  • accept cloud event message, it will record triggered pipelines, and calculate status according to these pipeline status

Todo:

  • accept tekton message still need testing
  • only support branch right now, devbuild usually use PR

jayl1e added 23 commits December 12, 2023 14:22
@jayl1e
feat: remove branch limitation
0dd16c1 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: support target image path after authenticate
1607d58 
Signed-off-by: lijie <[email protected]>
@jayl1e
test: add more test case
9a29651 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: use new type for ctx
0825f82 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: add confidential
b1bf599 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: cmd arg
20d0378 
Signed-off-by: lijie <[email protected]>
@jayl1e
doc: swagger
b64879b 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: pass param to jenkins
1fef7da 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: forbid target img and hotfix
79ad448 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: test
e4529c9 
Signed-off-by: lijie <[email protected]>
@jayl1e
refract: rename function
046682a 
Signed-off-by: lijie <[email protected]>
@jayl1e
refract: just simply global var
a515e9d 
Signed-off-by: lijie <[email protected]>
@jayl1e
refract: use pointer
007083b 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: rename api secret
1256f0b 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: support tekton event webhook
9a34ba4 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: support decode event
e2c2ee5 
Signed-off-by: lijie <[email protected]>
@jayl1e
Merge remote-tracking branch 'origin/main' into target_position
d7f005f
@jayl1e
feat: all trigger pipeline must be success
f777814 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: support trigger tekton
5cb1525 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: test
634af1e 
Signed-off-by: lijie <[email protected]>
@jayl1e
fix: skip test
0bfcbe1 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: rename tekton engine
b8c4dc3 
Signed-off-by: lijie <[email protected]>
@jayl1e
feat: support get hash
2b116b5 
Signed-off-by: lijie <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2024

I Skip it since the diff size(150036 bytes > 80000 bytes) is too large

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo January 5, 2024 09:49
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 22, 2024

I Skip it since the diff size(152229 bytes > 80000 bytes) is too large

wuhuizuo
wuhuizuo reviewed Feb 22, 2024
View reviewed changes
tibuild/api/api.go
@@ -15,6 +15,7 @@ import (
"github.com/PingCAP-QE/ee-apps/tibuild/internal/controller"
controllers "github.com/PingCAP-QE/ee-apps/tibuild/pkg/rest/controller"
"github.com/PingCAP-QE/ee-apps/tibuild/pkg/rest/service"
events "github.com/PingCAP-QE/ee-apps/tibuild/pkg/webhook/handler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use origin name handler

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 08:25:55.374787419 +0000 UTC m=+518444.122410525: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0f07b00 into main Feb 22, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tibuild-cloudevent branch February 22, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo approved these changes

@purelind purelind Awaiting requested review from purelind

Assignees

@wuhuizuo wuhuizuo

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayl1e @wuhuizuo