Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push tidb-backup-manager v2 only to GCR for now #559

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ideascf
Copy link
Contributor

@ideascf ideascf commented Feb 24, 2025

No description provided.

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo February 24, 2025 03:33
Copy link

ti-chi-bot bot commented Feb 24, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes

  • The pull request updates the delivery.yaml file to specify that only version v2 of tidb-backup-manager images should be pushed to gcr.io/pingcap-public/dbaas/tidb-backup-manager.

Potential Problems

  • The description for v1 version images is updated to mention v1, but the actual regex pattern is still for v2 versions. This could be a mistake.
  • The v2 version images are only being pushed to GCR (gcr.io/pingcap-public/dbaas/tidb-backup-manager). Make sure this is the intended behavior and aligns with the project's image distribution strategy.

Fixing Suggestions

  • Update the tags_regex for v1 version images to match the new description (e.g., ^(v1[.][0-9]+[.][0-9]+)(-.+)?$).
  • If pushing v2 version images only to GCR is intentional, ensure it is documented and aligns with the project's image distribution strategy. If there are additional repositories where v2 images should be pushed, update the dest_repositories accordingly.

Overall, it's important to ensure consistency between the image version descriptions and the regex patterns used to match those versions. Also, verify that the image distribution strategy aligns with project requirements.

@ti-chi-bot ti-chi-bot bot added the size/XS label Feb 24, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 24, 2025
Copy link

ti-chi-bot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-24 03:33:49.536029667 +0000 UTC m=+240377.489187931: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit b0cffda into PingCAP-QE:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants