Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): add image delivery rules #233

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 6, 2024

  • trunk branch images
  • release branch images

Signed-off-by: wuhuizuo [email protected]

- trunk branch images
- release branch images

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind February 6, 2024 10:18
Copy link

ti-chi-bot bot commented Feb 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of PR #X

Summary

This pull request adds image delivery rules to the delivery.yaml file. It includes new descriptions, tags, and destination repositories for various images.

Potential Problems

  • The description is very brief and does not explain the reasoning behind the changes.
  • There are no tests, which makes it difficult to verify if the changes are functioning as intended.
  • It's not clear if the new rules will conflict with existing ones.

Suggestions

  • Add more context to the PR description to explain the motivation behind the changes.
  • Create tests to verify that the new image delivery rules are working as intended.
  • Verify if there are any conflicts between the new and existing rules. If there are, those conflicts should be resolved before merging.

Overall, this PR seems to be adding useful functionality but needs more explanation and testing before it can be merged.

@ti-chi-bot ti-chi-bot bot added the size/L label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 6, 2024
Copy link

ti-chi-bot bot commented Feb 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 10:19:48.37625066 +0000 UTC m=+265713.943020551: ☑️ agreed by lijie0123.

Copy link

ti-chi-bot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 15abef2 into main Feb 6, 2024
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/update-delivery-config-for-images branch February 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants