Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): add enterprise-without-plugins profile for tidb repo #228

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 2, 2024

It will not build the go plugins, and it's valid from v7.1.0.

Signed-off-by: wuhuizuo [email protected]

It will not build the go plugins, and it's valid from v7.1.0.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind February 2, 2024 10:04
Copy link

ti-chi-bot bot commented Feb 2, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems that the change adds a new profile for the tidb repository, which is called enterprise-without-plugins. This profile will not build the Go plugins and will be valid from version 7.1.0.

There are a few potential problems that I can identify from the diff:

  • It's not clear what enterprise-prepare, enterprise-server-build, build_tools, and build_dumpling do, and whether they are required for the enterprise-without-plugins profile. This should be documented somewhere, either in the pull request description or in the repository's documentation.
  • It's not clear whether the new profile has been tested, and whether it works as intended. The pull request description doesn't mention any testing that has been done, and there are no new tests or changes to existing tests in the diff. It's important to test the new profile thoroughly to make sure that it doesn't introduce any unexpected issues.
  • It's not clear whether the new profile will work with other parts of the repository, such as the CI/CD pipeline. If the new profile is not compatible with the pipeline, it may cause issues when trying to build and deploy the application. This should be tested and documented as well.

To fix these potential problems, I would suggest the following:

  • Add documentation to the pull request description or to the repository's documentation to explain what each of the build steps in the enterprise-without-plugins profile does, and whether they are required.
  • Add tests for the new profile to ensure that it works as intended and doesn't introduce any unexpected issues.
  • Test the new profile with the CI/CD pipeline and document any changes that need to be made to ensure compatibility.

@ti-chi-bot ti-chi-bot bot added the size/XS label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 2, 2024
Copy link

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 10:05:42.409738685 +0000 UTC m=+1732783.974036390: ☑️ agreed by lijie0123.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7625c75 into main Feb 2, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tidb-add-new-profile branch February 2, 2024 10:06
wuhuizuo added a commit that referenced this pull request Feb 4, 2024
#228)

It will not build the go plugins, and it's valid from v7.1.0.

Signed-off-by: wuhuizuo <[email protected]>

Signed-off-by: wuhuizuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants