fix(packages): fix config for tidb-binlog and tidb-tools

[wuhuizuo]

• tidb-tools support Mac targets, we add it here.

Signed-off-by: wuhuizuo [email protected]

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Summary:

The pull request is for fixing the configuration of tidb-binlog and tidb-tools packages. The changes are adding support for Mac targets in tidb-tools. The diff contains changes in packages/offline-packages.yaml.tmpl, packages/packages.yaml.tmpl, and packages/scripts/ci.sh.

Potential Problems:

There are no potential problems found in the changes made in this pull request.

Fixing Suggestions:

No fixing suggestions needed as there are no potential problems found in the changes made in this pull request.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

This pull request updates the download links for etcd in the offline-packages.yaml.tmpl and packages.yaml.tmpl files to use the new URL format from the etcd-io organization on GitHub. It also adds support for Mac targets in tidb-tools by adding darwin to the os field in packages.yaml.tmpl. Additionally, it adds tidb-binlog and tidb-tools to the components field in scripts/ci.sh and adds them to the list of components in the test_gen_package_artifacts_script and test_gen_package_images_script functions in the same file.

Potential problems:

There seem to be no potential problems with this pull request.

Fixing suggestions:

No fixing suggestions are required.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
The pull request basically changes the URL for downloading etcd in two files packages/offline-packages.yaml.tmpl and packages/packages.yaml.tmpl. In addition to that, it adds support for Mac targets in tidb-tools.

There are no potential problems observed in this pull request.

Suggestion:

• It is good to add a more detailed description of the changes made in the pull request.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

• The pull request changes the URLs for etcd in packages.yaml.tmpl and offline-packages.yaml.tmpl files.
• It adds support for Mac targets in tidb-tools.
• It updates the ci.sh script to include tidb-binlog and tidb-tools in the package components.

Potential Problems:

• It is not clear why the changes for etcd URLs were made. The pull request description only mentions the addition of support for Mac targets in tidb-tools.
• It is not clear if the changes for etcd URLs were tested and if they work correctly.
• The if conditions for tidb-tools in packages.yaml.tmpl and offline-packages.yaml.tmpl only check for version constraints. It is possible that there are other conditions that need to be checked, such as operating system compatibility.
• The changes to the ci.sh script may need to be tested to ensure that they work correctly.

Fixing Suggestions:

• The pull request description should be updated to provide more information about the changes to etcd URLs and why they were made.
• The changes to etcd URLs should be tested to ensure that they work correctly.
• The if conditions for tidb-tools should be reviewed to ensure that all necessary conditions are checked.
• The changes to the ci.sh script should be tested to ensure that they work correctly.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment