Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Update acceptancetest_stop1.md #447

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Conversation

martiniil
Copy link
Contributor

  • We need to press acknowledge again after startup, else the controller is in holding mode.
  • Other minor fixes

We need to press acknowledge again after startup, else the controller is in holding mode.
@jschleicher
Copy link
Contributor

* We need to press acknowledge again after startup, else the controller is in holding mode.

Yes, that's the current behaviour - just tested with the PRBT. But from a user's perspective an incorrect assumption. Why shouldn't I be able to move the robot, if acknowledge is pressed during launch?
I don't like to change the acceptance test but rather fix the implementation. Is this a regression?

Copy link
Contributor

@jschleicher jschleicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving except second acknowledge, merging.

@jschleicher jschleicher merged commit d1e9879 into melodic-devel Oct 2, 2020
@jschleicher jschleicher deleted the fix/acceptance_test_stop1 branch October 2, 2020 13:46
@martiniil
Copy link
Contributor Author

martiniil commented Oct 5, 2020

* We need to press acknowledge again after startup, else the controller is in holding mode.

Yes, that's the current behaviour - just tested with the PRBT. But from a user's perspective an incorrect assumption. Why shouldn't I be able to move the robot, if acknowledge is pressed during launch?
I don't like to change the acceptance test but rather fix the implementation. Is this a regression?

We talked about this in the past (I think with @dbakovic). It is not a regression. But it doesn't matter since we agree that it should be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants