Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give gain slider more flexibility #272

Closed
calcmogul opened this issue Apr 21, 2021 · 3 comments
Closed

Give gain slider more flexibility #272

calcmogul opened this issue Apr 21, 2021 · 3 comments

Comments

@calcmogul
Copy link
Contributor

calcmogul commented Apr 21, 2021

There's currently one "gain" slider that ties the red and blue channels together, but low gain/exposure settings results in green images under fluorescent lighting. This is a problem if the target is lit green; the user has to use a much wider hue passband.

One solution to this would be separate red, green, and blue exposure sliders. A button could be added to autoselect the settings for them when the targeting LEDs are off (aka "auto white balance").

MATLAB's docs mention a few different algorithms that I imagine would be a starting point.
https://www.mathworks.com/help/images/comparison-of-auto-white-balance-algorithms.html

OpenCV has this, but idk if it's helpful: https://docs.opencv.org/4.5.2/d7/d71/classcv_1_1xphoto_1_1GrayworldWB.html

Another option is turning on auto white balance of the camera temporarily to get the values, then turn it back off.

@mcm001
Copy link
Contributor

mcm001 commented Apr 21, 2021

Per discussion on Discord:
We can expose the red and blue balances (raspicamcontrol_set_awb_gains), as well as expose contrast/saturation. We have control over the digital gain, but not analo. Those might best go under an advanced dropdown or something, as it's starting to get cluttered.

@mcm001
Copy link
Contributor

mcm001 commented Oct 2, 2021

The gain slider was previously broken; latest version shouldn't have this issue. Do we still think it's valuable to split the gain slider?

@gerth2
Copy link
Contributor

gerth2 commented Oct 2, 2021 via email

@gerth2 gerth2 closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants