-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give gain slider more flexibility #272
Comments
Per discussion on Discord: |
The gain slider was previously broken; latest version shouldn't have this issue. Do we still think it's valuable to split the gain slider? |
After playing with it myself .. I vote no, single slider works plenty well.
…On Sat, Oct 2, 2021, 9:07 AM Matt ***@***.***> wrote:
The gain slider was previously broken; latest version shouldn't have this
issue. Do we still think it's valuable to split the gain slider?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC7B3WE4UVJHBHI4WYPXLLUE4GZHANCNFSM43JOOSXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There's currently one "gain" slider that ties the red and blue channels together, but low gain/exposure settings results in green images under fluorescent lighting. This is a problem if the target is lit green; the user has to use a much wider hue passband.
One solution to this would be separate red, green, and blue exposure sliders. A button could be added to autoselect the settings for them when the targeting LEDs are off (aka "auto white balance").
MATLAB's docs mention a few different algorithms that I imagine would be a starting point.
https://www.mathworks.com/help/images/comparison-of-auto-white-balance-algorithms.html
OpenCV has this, but idk if it's helpful: https://docs.opencv.org/4.5.2/d7/d71/classcv_1_1xphoto_1_1GrayworldWB.html
Another option is turning on auto white balance of the camera temporarily to get the values, then turn it back off.
The text was updated successfully, but these errors were encountered: