This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Add colored shape page #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurrani808
previously requested changes
Nov 29, 2021
There was a problem hiding this comment.
Thoughts on changing up the pipeline section to add a new page on what a pipeline (called about pipelines) is that talks about the two different types of pipelines and then in the countor grouping section we divide that up into reflective vs. colored shape? Most of the information you have here could just be copied over to those respective sections.
Would be helpful organization wise and for those who are completely new to vision processing and don't know what a pipeline is. Also makes it more versatile for if we ever decide to add another pipeline type in the future.
mcm001
previously approved these changes
Dec 4, 2021
mdurrani808
reviewed
Dec 4, 2021
Closed
4 tasks
mcm001
approved these changes
Dec 13, 2021
jasondaming
dismissed
mdurrani808’s stale review
I am not sure what that would look like or what we would say beyond the self explanatory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114