Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for numpy2.0 #177

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix for numpy2.0 #177

merged 1 commit into from
Jun 17, 2024

Conversation

Intron7
Copy link
Contributor

@Intron7 Intron7 commented Jun 17, 2024

numpy 2.0 deprecated np.Inf and needs np.inf now

@Phlya
Copy link
Owner

Phlya commented Jun 17, 2024

Nice, thanks a lot! Is this the only change required for numpy 2.0?

@Intron7
Copy link
Contributor Author

Intron7 commented Jun 17, 2024

I don't know 100%. But that's something a CI complained about. And it was the only with regarding your package.

@Phlya
Copy link
Owner

Phlya commented Jun 17, 2024

OK, for now I'll just merge this and will test it with numpy 2.0 when I have time. Hopefully this is all that's needed.

@Phlya Phlya merged commit fc3dc4b into Phlya:master Jun 17, 2024
1 check passed
has2k1 added a commit to has2k1/plotnine that referenced this pull request Jun 22, 2024
Un skip when the support 2.0 is released.

ref: Phlya/adjustText#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants