Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting of updatetime #4

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

willwillsiii
Copy link
Contributor

@willwillsiii willwillsiii commented Mar 14, 2023

Fixed #3.

With this pull request, all mentions of the updatetime option are removed. This is to make this plugin play nice with others. The use of separate autocommands to change and then reset the setting allowed there to be possible interference.

With no way to guarantee that it's correctly being set, updatetime is now left untouched by this plugin.

Copy link
Owner

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @willwillsiii. Just change the PR's description text to match what's now happening in the code, and I'll merge.

@willwillsiii willwillsiii changed the title Reset updatetime to value at load Remove setting of updatetime Mar 22, 2023
@willwillsiii
Copy link
Contributor Author

Thanks, just updated the title! Sorry for the wait.

@PhilRunninger PhilRunninger merged commit 49ef587 into PhilRunninger:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwrites updatetime if not set to default value
2 participants