Fix crash on inaccessible directory #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qmarkdown crashes if a directory with inaccessible permissions (e.g. owner root, mode 0700) is encountered while scanning the
workspace. The crash is caused by an exception which is thrown by the
fs::directory_iterator
.This is similar to the fix I have done here, but unfortunately a little less pretty in the case of
auto_complete
where we don't need any recursion: the legacy APIstd::experimental::filesystem::directory_iterator::directory_iterator
does not provide the option to setdirectory_options
in the second argument, so I had to switch to the recursive version and bail out on depth > 0. In the case ofresgen.cpp
it removes the need for manual recursion.