Remove old opmath #6548
Merged
Remove old opmath #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into remove_old_opmath
lillian542
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Nov 13, 2024
We are removing the Tensor and Hamiltonian classes, so we should remove their (minimal) remaining references in the Lightning python code. Blocks running CI for the [PL PR #6548](PennyLaneAI/pennylane#6548) to remove legacy_opmath, since every test that uses `lightning.qubit` fails with Tensor removed. --------- Co-authored-by: ringo-but-quantum <[email protected]>
lillian542
commented
Nov 14, 2024
lillian542
commented
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
astralcai
reviewed
Nov 14, 2024
Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
astralcai
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
It's time to fully remove the legacy operator arithmetic (
Tensorandqml.ops.Hamiltonian, and all of the structure surrounding them).Description of the Change:
qml.ops.HamiltonianTensordisable_andenable_new_opmathoperation.convert_to_legacy_Hqml.pauli.simplifyPauliWord.hamiltonianandPauliSentence.hamiltonian, and any other functionality in the pauli module that supported legacy opmathlegacy_opmath_only,new_opmath_onlyanduse_legacy_and_new_opmathtest fixtures, and all irrelevant tests[sc-77523]