Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Operator.expand function #5994

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Deprecate Operator.expand function #5994

merged 14 commits into from
Jul 19, 2024

Conversation

Shiro-Raven
Copy link
Contributor

@Shiro-Raven Shiro-Raven commented Jul 12, 2024

Deprecated since it is redundant bloat and can be done manually pretty easily.

[sc-65069]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (3fbfe09) to head (c46cd6b).
Report is 286 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5994      +/-   ##
==========================================
+ Coverage   99.59%   99.65%   +0.05%     
==========================================
  Files         427      427              
  Lines       41719    40745     -974     
==========================================
- Hits        41551    40605     -946     
+ Misses        168      140      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shiro-Raven Shiro-Raven enabled auto-merge (squash) July 19, 2024 02:05
@Shiro-Raven Shiro-Raven merged commit 285c3a6 into master Jul 19, 2024
40 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/deprecate-op-expand branch July 19, 2024 02:44
astralcai added a commit to PennyLaneAI/pennylane-lightning that referenced this pull request Aug 12, 2024
`Operator.expand` is deprecated
(PennyLaneAI/pennylane#5994).
`Operator.decomposition` should be used instead.

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
multiphaseCFD pushed a commit to PennyLaneAI/pennylane-lightning that referenced this pull request Aug 13, 2024
`Operator.expand` is deprecated
(PennyLaneAI/pennylane#5994).
`Operator.decomposition` should be used instead.

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants