Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining references to legacy operator arithmetic #997

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Remove remaining references to legacy operator arithmetic #997

merged 9 commits into from
Nov 18, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Nov 18, 2024 •
edited
Loading

Context:
The test matrix indicates that there are a few more updates needed to the lightning tests before they can pass with the latest version of PennyLane, now that legacy operator arithmetic has been removed.

Description of the Change:
Remove checks for legacy operator arithmetic in the tests

[sc-77523]

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@maliasadi maliasadi added ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.14%. Comparing base (3abd17d) to head (f73a336).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/_measurements.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
- Coverage   93.93%   92.14%   -1.79%     
==========================================
  Files         231      104     -127     
  Lines       36191    16266   -19925     
==========================================
- Hits        33996    14989   -19007     
+ Misses       2195     1277     -918

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

astralcai
astralcai approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmintorDusko
Copy link
Contributor

Hey folks, I re-ran the failed tests (with this branch), so we can better assess the situation.
latest-latest
latest-stable
stable-latest

maliasadi
maliasadi approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lillian542! 🤩

@lillian542 lillian542 merged commit ad205ee into master Nov 18, 2024
92 of 94 checks passed
@lillian542 lillian542 deleted the remove_legacy_opmath2 branch November 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliasadi maliasadi maliasadi approved these changes

@astralcai astralcai astralcai approved these changes

Assignees
No one assigned
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lillian542 @AmintorDusko @maliasadi @astralcai @ringo-but-quantum