LGPU-MPI installation instruction update and missing lib message update #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 97.67% 92.77% -4.91%
==========================================
Files 228 116 -112
Lines 36405 18400 -18005
==========================================
- Hits 35560 17070 -18490
- Misses 845 1330 +485 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
added
the
ci:use-multi-gpu-runner
maliasadi
reviewed
Nov 11, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/CMakeLists.txt
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/CMakeLists.txt
Outdated
Show resolved
Hide resolved
maliasadi
reviewed
Nov 12, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/CMakeLists.txt
Outdated
Show resolved
Hide resolved
multiphaseCFD
requested review from
maliasadi,
mlxd,
LuisAlfredoNu,
josephleekl and
AmintorDusko
multiphaseCFD
changed the title
multiphaseCFD
removed
the
ci:use-multi-gpu-runner
multiphaseCFD
added
the
ci:use-multi-gpu-runner
josephleekl
reviewed
Nov 25, 2024
|
Thanks @multiphaseCFD ! Just left a few quick questions, happy to approve once they're answered :) |
josephleekl
reviewed
Nov 25, 2024
maliasadi
approved these changes
Nov 25, 2024
josephleekl
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[SC-72314]
This PR is related the issue.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: