Integrate LGPU to Catalyst #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
… Lightning (#924) Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [ ] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-74415] --------- Co-authored-by: ringo-but-quantum <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.39.0_rc #928 +/- ##
=============================================
Coverage ? 97.95%
=============================================
Files ? 255
Lines ? 38096
Branches ? 0
=============================================
Hits ? 37316
Misses ? 780
Partials ? 0 ☔ View full report in Codecov by Sentry. |
maliasadi
reviewed
Oct 29, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/catalyst/CMakeLists.txt
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/catalyst/LightningGPUObsManager.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/catalyst/LightningGPUSimulator.cpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/catalyst/LightningGPUSimulator.hpp
Outdated
Show resolved
Hide resolved
...lightning/core/src/simulators/lightning_gpu/catalyst/tests/runner_lightning_gpu_catalyst.cpp
Outdated
Show resolved
Hide resolved
paul0403
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Thanks! No major complaints from my end 🎈
After #960 is merged, we will have all lightning.qubit/kokkos/gpu's catalyst api in lightning repository proper. There is a significant amount of overlapping code, so we can finally refactor then!
Thanks @paul0403 ! As you said, refactoring is definitely next step. |
maliasadi
approved these changes
Oct 30, 2024
...lightning/core/src/simulators/lightning_gpu/catalyst/tests/runner_lightning_gpu_catalyst.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[SC-73065]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: