Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic numbers in Lightning stopping_conditions #926

Merged
merged 7 commits into from
Sep 30, 2024

trigger ci

90232a1
Select commit
Loading
Failed to load commit list.
Merged

Remove magic numbers in Lightning stopping_conditions #926

trigger ci
90232a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 27, 2024 in 0s

69.82% (-27.42%) compared to c607b6c

View this Pull Request on Codecov

69.82% (-27.42%) compared to c607b6c

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (c607b6c) to head (90232a1).

❗ There is a different number of reports uploaded between BASE (c607b6c) and HEAD (90232a1). Click for more details.

HEAD has 101 uploads less than BASE
Flag BASE (c607b6c) HEAD (90232a1)
108 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #926       +/-   ##
===========================================
- Coverage   97.23%   69.82%   -27.42%     
===========================================
  Files         214       24      -190     
  Lines       29802     2283    -27519     
===========================================
- Hits        28978     1594    -27384     
+ Misses        824      689      -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.